Skip to content

Conversation

@cedoor
Copy link
Contributor

@cedoor cedoor commented May 9, 2024

Description

This PR moves the eddsa-proof package and its circuit from the ZK-Kit repo to this one and renames it to identity-proof, as the circuit is actually quite related to Semaphore. The circuit has also been updated to reflect the recent changes in the Semaphore circuit (Baby Jubjub bug).

identity-proof allows devs to prove they own a Semaphore identity without revealing the private key.

Before merging this PR, it is necessary to update the SNARK artifacts on the snark-artifacts repo.

Related Issue(s)

Re zk-kit/zk-kit#282

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have run yarn style without getting any errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@cedoor cedoor requested a review from vplasencia May 9, 2024 17:10
@vercel
Copy link

vercel bot commented May 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
semaphore-benchmarks ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2024 5:49pm

@cedoor cedoor changed the title Feat/identity proof feat(identity-proof): add identity-proof circuit/package May 9, 2024
@cedoor cedoor force-pushed the feat/identity-proof branch from f1e3bd3 to fc4ea04 Compare May 20, 2024 17:16
@cedoor cedoor merged commit 7e5b5f3 into main May 20, 2024
@cedoor cedoor deleted the feat/identity-proof branch May 20, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants