Skip to content

feat(explorer): add filter groups by admin #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2024
Merged

feat(explorer): add filter groups by admin #24

merged 1 commit into from
Dec 2, 2024

Conversation

@vplasencia
Copy link
Member

@vplasencia vplasencia commented Dec 2, 2024

Description

This PR adds support to filter groups by admin.

Related Issue(s)

Closes #23

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run yarn style without getting any errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@vplasencia vplasencia requested a review from a team as a code owner December 2, 2024 11:41
@vercel
Copy link

vercel bot commented Dec 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
semaphore-benchmarks ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 11:43am
semaphore-explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 11:43am

cedoor
cedoor approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@cedoor cedoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

@cedoor cedoor merged commit b86fb46 into main Dec 2, 2024
5 checks passed
@cedoor cedoor deleted the feat/explorer-filter-by-admin branch December 2, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cedoor cedoor cedoor approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Explorer: Filter groups by admin

3 participants

@vplasencia @cedoor