Skip to content

feat(data): add semaphore event listeners #1054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 23, 2025
Merged

feat(data): add semaphore event listeners #1054

merged 11 commits into from
Oct 23, 2025

Conversation

@Lauman
Copy link
Contributor

@Lauman Lauman commented Oct 20, 2025 •
edited
Loading

Description

The following listeners have been added to the SemaphoreEthers class:

  • onGroup (GroupCreated event): Return the ID of the newly created group.
  • onMember (MemberRemoved, MemberUpdated, MemberAdded events): Return the identity confirmation of the added, updated, or deleted members. For updates , the previous identity confirmation is returned.
  • onValidatedProof (ProofValidated event): Return the parameters of a validated proof.
  • onGroupAdmin (GroupAdminUpdated event): Return the addresses of the old and new admins.

Related Issue(s)

#326

Checklist

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run yarn format and yarn lint without getting any errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Lauman Lauman requested a review from a team as a code owner October 20, 2025 22:11
@vplasencia vplasencia linked an issue Oct 23, 2025 that may be closed by this pull request
Add Semaphore event listeners #326
Closed
vplasencia
vplasencia reviewed Oct 23, 2025
View reviewed changes
Copy link
Member

@vplasencia vplasencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Lauman! Thank you very much for creating this PR. Great work! I added some comments.

Lauman added 2 commits October 23, 2025 11:11
@Lauman
feat(data): feat(data): add semaphore event listeners
dc7cd20 
the onMember method is separated and some names are adjusted

BREAKING CHANGE: N

re semaphore-protocol#326
@Lauman
feat(data): feat(data): add semaphore event listeners
4d31138 
the onMember method is separated and some names are adjusted

BREAKING CHANGE: N

re semaphore-protocol#326
@Lauman Lauman requested a review from vplasencia October 23, 2025 14:22
vplasencia
vplasencia requested changes Oct 23, 2025
View reviewed changes
Copy link
Member

@vplasencia vplasencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the updates. Just a few small changes and the PR is ready to be merged.

@Lauman
feat(data): feat(data) add semaphore event listeners
86a07d7 
add missing merkleTreeRoot element in onMember events

re semaphore-protocol#326
@Lauman Lauman requested a review from vplasencia October 23, 2025 18:33
vplasencia
vplasencia requested changes Oct 23, 2025
View reviewed changes
Lauman added 2 commits October 23, 2025 17:15
@Lauman
feat(data): feat(data) add semaphore event listeners
4d55a86 
fix name listener of GroupAdminUpdated event

re semaphore-protocol#326
@Lauman
feat(data): feat(data) add semaphore event listeners
238b80d 
add groupId param to listener onGroupAdminUpdated

re semaphore-protocol#326
@Lauman Lauman requested a review from vplasencia October 23, 2025 20:25
vplasencia
vplasencia reviewed Oct 23, 2025
View reviewed changes
Copy link
Member

@vplasencia vplasencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding short descriptions (as code comments before the function declarations similar to the other functions) for the functions that remove listeners? That way all the functions will have consistent documentation.

@Lauman
feat(data): feat(data) add semaphore event listeners
5700323 
Add short descriptions to off listeners methods

re semaphore-protocol#326
@Lauman
Copy link
Contributor Author

Lauman commented Oct 23, 2025

short descriptions

No problem. Done.

@Lauman Lauman requested a review from vplasencia October 23, 2025 21:43
vplasencia
vplasencia approved these changes Oct 23, 2025
View reviewed changes
Copy link
Member

@vplasencia vplasencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @Lauman! Thank you very much! 🚀

@vplasencia vplasencia merged commit b55bf7f into semaphore-protocol:main Oct 23, 2025
2 of 4 checks passed
@gitpoap-bot
Copy link

gitpoap-bot bot commented Oct 23, 2025

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2025 Semaphore Contributor:

GitPOAP: 2025 Semaphore Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vplasencia vplasencia vplasencia approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Semaphore event listeners

2 participants

@Lauman @vplasencia