-
Notifications
You must be signed in to change notification settings - Fork 97
Comprehensive user behavior testing #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
feat: add TS support
fix: moved tests to RNTL
feat: add react-navigation and screens
fix: lint issues feat: autocomplete hook feat: theme components Input, Icon, IconButton test: app snapshot updated to add testID
feat: add country selection
|
@zsajjad Thanks for this. Do you have any thoughts on why the build on Semaphore is failing? We can't merge anything if the build is red. |
|
@markoa its passing all checks now. |
|
Hi @zsajjad, great news on the first pipeline. Unfortunately, it seems like the iOS build block is failing on the second pipeline after the promotion: |
|
@AleksandarCole can you please trigger build again. |
|
@zsajjad We've given you access to the repo on GitHub and organization on Semaphore so that you can trigger the promotion yourself. |
|
Thanks @markoa |
|
It passed! 🥳 🎊 |
In order to make our demo app close to real life applications, I have added 2 screens to application.
PR Details
User Story
App starts from same react native's default screen with small additions of toggle button and a button to navigate to search screen. On search screen there is an autocomplete to search from list of countries. User can select a country and that will be stored in local storage. On next app launch this screen will display the selected country. Selected country can be removed by pressing the on item.
Notes
I have retained all the current tests, just refactored them to RNTL.