Skip to content

Conversation

@hamir-suspect
Copy link
Contributor

📝 Description

The previous Google Cloud OIDC configuration had several problems:

  1. Circular configuration: Set google.subject to a static value, then checked if it equals that same static value
  2. Length limitation: Semaphore's JWT subject often exceeds Google Cloud's 127-byte limit
  3. No actual access control: The condition would always be true, defeating the security purpose

✅ Checklist

  • I have tested this change
  • This change requires documentation update

@hamir-suspect hamir-suspect merged commit 602348e into main Sep 3, 2025
2 checks passed
@hamir-suspect hamir-suspect deleted the has/docs/fix-oidc-gcp branch September 3, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

3 participants