Skip to content

fix(front): HTML sanitize test reports #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 8, 2025
Merged

fix(front): HTML sanitize test reports #561

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9e7cd31
HTML sanitize test reports
VeljkoMaksimovic Sep 5, 2025
35dc18e
Use backtick instead of single quote
VeljkoMaksimovic Sep 8, 2025
279264b
Remove a tag and href from allowelist
VeljkoMaksimovic Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion front/assets/js/flaky_tests/components/actions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import * as types from "../types";
import { auto } from "@popperjs/core";
import { Headers } from "../network/request";
import * as marked from "marked";
import DOMPurify from "dompurify";

export const Actions = ({ item }: { item: FlakyTestItem, }) => {
const config = useContext(stores.Config.Context);
Expand Down Expand Up @@ -157,7 +158,18 @@ const TicketDetail = (props: TicketDetailProps) => {
**Commit**: ${props.item.latestDisruptionSha()}

**File**: ${props.item.testFile}`;
return marked.parse(markdown);

const rawHtml = marked.parse(markdown);
return DOMPurify.sanitize(rawHtml, {
ALLOWED_TAGS: [
`h1`, `h2`, `h3`, `h4`, `h5`, `h6`,
`p`, `br`, `strong`, `em`, `u`, `strike`,
`ul`, `ol`, `li`,
`blockquote`, `code`, `pre`
],
ALLOWED_ATTR: [`title`],
ALLOWED_SCHEMES: [`http`, `https`, `mailto`]
});
};


Expand Down