Skip to content

fix(front): fix overflowing service account role selection dropdown #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 7, 2025
+18 −4
Merged

fix(front): fix overflowing service account role selection dropdown #629

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97322e7
fix(front): fix overflowing service account role selection dropdown
hamir-suspect Oct 6, 2025
aa1ca0b
Merge branch 'main' into has/front/fix-overflow
hamir-suspect Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions front/assets/js/service_accounts/components/CreateServiceAccount.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ export const CreateServiceAccount = ({ isOpen, onClose, onCreated }: CreateServi

const canSubmit = name.trim().length > 0 && selectedRoleId.length > 0 && !loading;

const selectedRole = config.roles.find((role) => role.id === selectedRoleId);

return (
<Modal isOpen={isOpen} close={handleClose} title="Create Service Account">
{!token ? (
Expand Down Expand Up @@ -92,11 +94,16 @@ export const CreateServiceAccount = ({ isOpen, onClose, onCreated }: CreateServi
>
<option value="">Select a role...</option>
{config.roles.map((role) => (
<option key={role.id} value={role.id}>
{role.name} - {role.description}
<option key={role.id} value={role.id} title={`${role.name} - ${role.description}`}>
{role.name}
</option>
))}
</select>
{selectedRole && (
<p className="mt2 mb0 f6 mid-gray">
{selectedRole.description}
</p>
)}
</div>

{error && (
Expand Down
11 changes: 9 additions & 2 deletions front/assets/js/service_accounts/components/EditServiceAccount.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,8 @@ export const EditServiceAccount = ({

if (!serviceAccount) return null;

const selectedRole = config.roles.find((role) => role.id === selectedRoleId);

return (
<Modal isOpen={isOpen} close={handleClose} title="Edit Service Account">
<form onSubmit={(e) => void handleSubmit(e)}>
Expand Down Expand Up @@ -109,11 +111,16 @@ export const EditServiceAccount = ({
>
<option value="">Select a role...</option>
{config.roles.map((role) => (
<option key={role.id} value={role.id}>
{role.name} - {role.description}
<option key={role.id} value={role.id} title={`${role.name} - ${role.description}`}>
{role.name}
</option>
))}
</select>
{selectedRole && (
<p className="mt2 mb0 f6 mid-gray">
{selectedRole.description}
</p>
)}
</div>

{error && (
Expand Down