fix: service account project creation #635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enables service accounts to create projects with GitHub App integrations while preventing them from using OAuth integrations. The changes add proper validation to block service accounts from using OAuth tokens and provide clear error messages when this is attempted.
Key changes:
- Added service account detection logic to prevent OAuth token usage
- Implemented special permission handling for service accounts with GitHub App integration
- Enhanced test coverage with mocks for user client describe functionality
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| repository_hub/lib/repository_hub/adapters/github/create_action.ex | Added service account support for GitHub App integration with admin permissions |
| repository_hub/lib/repository_hub/adapters/github_adapter.ex | Added OAuth token validation to block service accounts |
| repository_hub/lib/repository_hub/adapters/gitlab_adapter.ex | Added OAuth token validation to block service accounts |
| repository_hub/lib/repository_hub/adapters/bitbucket_adapter.ex | Added OAuth token validation to block service accounts |
| repository_hub/lib/internal_api/user.pb.ex | Added SERVICE_ACCOUNT enum value for user creation source |
| repository_hub/test/repository_hub/adapters/github/create_action_test.exs | Added tests for service account behavior with different integration types |
| repository_hub/test/repository_hub/adapters/github/list_accessible_repositories_action_test.exs | Added describe mock for user client testing |
| repository_hub/test/support/factories/git_clients/gitlab_client_factory.ex | Added user client mocks for testing |
| repository_hub/test/support/factories/git_clients/bitbucket_client_factory.ex | Added user client mocks for testing |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
skipi
previously approved these changes
Oct 10, 2025
hamir-suspect
force-pushed
the
has/service-account-project-create
branch
from
126f4b3 to
255d60c
Compare
VeljkoMaksimovic
approved these changes
Oct 10, 2025
forestileao
approved these changes
Oct 10, 2025
hamir-suspect
added a commit
that referenced
this pull request
Oct 10, 2025
## 📝 Description Allows service account to create a project with `github_app` type of integration and returs better errors for `oauth` integrations. Adressing #632 ## ✅ Checklist - [x] I have tested this change - [ ] This change requires documentation update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Allows service account to create a project with
github_apptype of integration and returs better errors foroauthintegrations. Adressing #632✅ Checklist