toil(front): update alpine image to 3.22.2 #692
Conversation
skipi
requested review from
DamjanBecirovic,
forestileao and
hamir-suspect
as code owners
skipi
force-pushed
the
mk/front/update-alpine-image
branch
3 times, most recently
from
6cb1d58 to
beb84e8
Compare
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
skipi
force-pushed
the
mk/front/update-alpine-image
branch
from
3427c62 to
ececac4
Compare
skipi
changed the title
skipi
force-pushed
the
mk/front/update-alpine-image
branch
5 times, most recently
from
70ef81a to
f015a8a
Compare
|
Code looks good, but please ask the agent to add the details about using the new |
skipi
force-pushed
the
mk/front/update-alpine-image
branch
from
39ff3ec to
8af8f5c
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| defmacro browser_test(message, context \\ quote(do: _), contents) do | ||
| context = Macro.escape(context) | ||
| contents = Macro.escape(contents, unquote: true) | ||
|
|
||
| quote bind_quoted: [context: context, contents: contents, message: message] do | ||
| name = ExUnit.Case.register_test(__MODULE__, __ENV__.file, __ENV__.line, :test, message, []) | ||
|
|
||
| def unquote(name)(unquote(context)) do | ||
| unquote(contents) | ||
| rescue |
There was a problem hiding this comment.
The new browser_test/3 macro stores the block in contents but never unwraps the do: value. When the macro is expanded, contents is a keyword list ([do: ...]) and the generated test function body is simply that list, so the code inside the do block is never executed. All browser specs defined with browser_test will therefore pass without running any assertions or interactions. Extract the actual block (contents[:do]) or pattern match do: contents so the macro executes the user-provided code.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
By using the unquote: true option in Macro.escape/2, we ensure that the passed block actually executes.
📝 Description
Bumped the CI image to Alpine 3.20+, updated wallaby to comply with the new ChromeDriver version
Hardened our Wallaby helpers to handle DOM refreshes/retries, then applied them across the suite (flash assertions, modal submits, Okta setup, artifacts policies, etc.) so the worst flakes are gone
Stabilized the stubborn cases (self‑hosted agents page, artifacts retention editor, Okta integration flows) by waiting on the right UI hooks instead of the old modal DOM
✅ Checklist