-
Notifications
You must be signed in to change notification settings - Fork 71
fix(guard): avoid login lookup failures without RHA #702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Invitation occasionally fails because we can’t fetch the inviter’s repo host account (RHA), so token lookup crashes the flow. Since these calls hit public endpoints, we now proceed without a token when the RHA is missing, keeping invitations functional. GitLab integration was also fixed. Previously never worked because it hit the wrong endpoint/token path.
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
|
@codex review |
1 similar comment
|
@codex review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
📝 Description
Invitation occasionally fails because we can’t fetch the inviter’s repo host account (RHA), so token lookup crashes the flow. Since these calls hit public endpoints, we now proceed without a token when the RHA is missing, keeping invitations functional.
GitLab integration was also fixed. We also removed the token from GitLab requests. Fetching the user API token for GitLab is not working properly, and we will address this issue in another PR.
✅ Checklist
This change requires documentation update