MCP server: Add usage metrics #711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DamjanBecirovic
requested review from
dexyk and
hamir-suspect
as code owners
skipi
approved these changes
Nov 12, 2025
Collaborator
Author
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
dexyk
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Instrument every MCP tool with the new
shared.TrackToolExecutionhelper so each handler automatically emitstools.<tool_name>.count_*andduration_msmetrics, marking success viatracker.MarkSuccess()just before returning.Tag metrics with human-readable organization names by introducing a cached org-name resolver (pkg/tools/internal/shared/org_resolver.go) wired through
tools.ConfigureMetrics(provider)(called once during server bootstrap) and backed by the organization gRPC client + stub support.Document the workflow in
AGENTS.mdso future tools follow the same pattern, and add targeted unit tests for both the metrics helper and resolver caching logic.✅ Checklist
This change requires documentation update