Skip to content

Conversation

@OnestarLee
Copy link
Collaborator

@OnestarLee OnestarLee commented Nov 18, 2025

External Contributions

This project is not yet set up to accept pull requests from external contributors.

If you have a pull request that you believe should be accepted, please contact
the Developer Relations team developer-advocates@sendbird.com with details
and we'll evaluate if we can setup a CLA to allow for the contribution.

For Internal Contributors

[CLNP-7756](https://sendbird.atlassian.net/browse/CLNP-7756)

Description Of Changes

@openspacelabs/react-native-zoomable-view 최신 API지원하도록 수정하였습니다

Types Of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply_

  • Bugfix
  • New feature
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance (ex) Prettier)
  • Build configuration
  • Improvement (refactor code)
  • Test

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 10.85%. Comparing base (940823e) to head (167cee2).

Files with missing lines Patch % Lines
...ve/src/components/FileViewer/FileViewerContent.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #276   +/-   ##
=======================================
  Coverage   10.85%   10.85%           
=======================================
  Files         360      360           
  Lines        9049     9049           
  Branches     2574     2557   -17     
=======================================
  Hits          982      982           
  Misses       7991     7991           
  Partials       76       76           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot finished reviewing on behalf of OnestarLee November 18, 2025 06:08
@OnestarLee OnestarLee requested a review from bang9 November 18, 2025 06:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the @openspacelabs/react-native-zoomable-view dependency to support the latest API (version 2.4.2) and refactors the zoomProps handling accordingly.

  • Updated dependency from <2.3.0 to ^2.3.0 (locked at version 2.4.2)
  • Changed touch event handler from onTouchEnd to onSingleTap to align with the new API
  • Improved type safety by using Partial<ReactNativeZoomableViewProps> and explicit typing for content size properties

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
yarn.lock Updates the locked version of @openspacelabs/react-native-zoomable-view from 2.2.0 to 2.4.2
packages/uikit-react-native/package.json Updates dependency constraint from <2.3.0 to ^2.3.0 to support newer versions
packages/uikit-react-native/src/components/FileViewer/FileViewerContent.tsx Refactors zoomProps to use onSingleTap instead of onTouchEnd and improves type definitions for better type safety

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Collaborator

@bang9 bang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@OnestarLee OnestarLee added this pull request to the merge queue Nov 21, 2025
Merged via the queue into main with commit 96f85a2 Nov 21, 2025
13 checks passed
@OnestarLee OnestarLee deleted the feat/migrate-zoomable-view-version branch November 21, 2025 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants