Skip to content

fix: Fix scroll issue on the AddOperatorsModal and MutedMembersModal #1014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 14, 2024
Merged

fix: Fix scroll issue on the AddOperatorsModal and MutedMembersModal #1014

merged 2 commits into from
Mar 14, 2024

Conversation

@HoonBaek
Copy link
Contributor

@HoonBaek HoonBaek commented Mar 14, 2024

ChangeLog & Fix

  • Fixed a specific environment issue (Android emulator) - Resolved an issue in modals used in ChannelSettings such as MembersModal, MutedMembersModal, OperatorsModal, BannedUsersModal, AddOperatorsModal, where even when scrolling to the end, additional members were not fetched

@HoonBaek HoonBaek requested review from AhyoungRyu and chohongm March 14, 2024 02:53
@HoonBaek HoonBaek self-assigned this Mar 14, 2024
@HoonBaek HoonBaek requested a review from bang9 March 14, 2024 04:54
chohongm
chohongm approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@chohongm chohongm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HoonBaek HoonBaek merged commit 7af1755 into main Mar 14, 2024
@HoonBaek HoonBaek deleted the fix/ScrollIssue-on-modal-list-in-AOS branch March 14, 2024 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AhyoungRyu AhyoungRyu Awaiting requested review from AhyoungRyu

@bang9 bang9 Awaiting requested review from bang9

1 more reviewer

@chohongm chohongm chohongm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@HoonBaek HoonBaek

Labels

v3.13.2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HoonBaek @chohongm