bug-fix: Fix carousel swipe flickering issue + Add missing default font-family to template root #1022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chohongm
force-pushed
the
temp/testing-carousel-motions
branch
from
abf4e55 to
5127f7a
Compare
HoonBaek
approved these changes
Mar 22, 2024
src/ui/Carousel/index.tsx
Outdated
Comment on lines
182
to
184
| const handleTouchEnd = () => { | ||
| if (dragging !== null) { | ||
| setDragging(null); | ||
| } | ||
| onDragEnd(); | ||
| handleDragEndForMobile(); | ||
| }; |
Contributor
There was a problem hiding this comment.
same?
const handleTouchEnd = handleDragEndForMobile;
src/ui/Carousel/index.tsx
Outdated
| }); | ||
| return; | ||
| } | ||
| if (deltaY > deltaX + 15) { |
Contributor
There was a problem hiding this comment.
better to make these 15 to constance
chohongm
force-pushed
the
temp/testing-carousel-motions
branch
from
85a6b63 to
c8bfdaa
Compare
- resolve carousel flickering issue in mobile devices
chohongm
force-pushed
the
temp/testing-carousel-motions
branch
from
6a5238e to
7aadd73
Compare
chohongm
added a commit
that referenced
this pull request
Mar 27, 2024
…nt-family to template root (#1022) ### Changelogs - Fixed a bug where swiping carousel in mobile view displaying flickering effect - Added missing default font-family value to template root
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelogs