Skip to content

bug-fix: Added error catch in malformed template payload #1033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 29, 2024
Merged

bug-fix: Added error catch in malformed template payload #1033

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cecfb35
Added error catch logic in message template payload handling
chohongm Mar 29, 2024
9a26222
Update src/ui/TemplateMessageItemBody/index.tsx
chohongm Mar 29, 2024
1ee101b
apply feeds
chohongm Mar 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 17 additions & 11 deletions src/ui/TemplateMessageItemBody/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,19 +138,25 @@ export function TemplateMessageItemBody({
nonCachedTemplateKeys.push(templateKey);
}
if (templateData.view_variables) {
// eslint-disable-next-line @typescript-eslint/no-unused-vars
Object.entries(templateData.view_variables).forEach(([_, simpleTemplateDataList]) => {
simpleTemplateDataList.forEach((simpleTemplateData: SimpleTemplateData) => {
const simpleTemplateKey = simpleTemplateData?.key;
if (simpleTemplateKey) {
if (!getCachedTemplate(simpleTemplateKey)) {
if (simpleTemplateKey && nonCachedTemplateKeys.indexOf(simpleTemplateKey) === -1) {
nonCachedTemplateKeys.push(simpleTemplateKey);
}
try {
// eslint-disable-next-line @typescript-eslint/no-unused-vars
Object.entries(templateData.view_variables).forEach(([_, simpleTemplateDataList]) => {
simpleTemplateDataList.forEach((simpleTemplateData: SimpleTemplateData) => {
const simpleTemplateKey = simpleTemplateData?.key;
if (
simpleTemplateKey
&& !getCachedTemplate(simpleTemplateKey)
&& !nonCachedTemplateKeys.includes(simpleTemplateKey)
) {
nonCachedTemplateKeys.push(simpleTemplateKey);
}
}
});
});
});
} catch (e) {
logger.error('TemplateMessageItemBody | received view_variables is malformed: ', templateData);
result.isErrored = true;
return result;
}
}
try {
if (nonCachedTemplateKeys.length > 0) {
Expand Down