feat: support carousel template with simple templates #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

chohongm merged 12 commits into v3.14.0-beta-1 from feat/v3/AC-1230-support-carousel-template-with-simple-templates

Apr 1, 2024

Contributor

chohongm commented Apr 1, 2024

Carousel templates created with direct simple templates in items (no reservations keys) should be suppported as fallback logic.

ex.

timestamp location of carousel template body must be dynamically updated.
For composite template, template version should be max of (composite + its simple templstes).

chohongm added 3 commits

April 1, 2024 15:53


          Support carousel template with simple templates

e12f782


          Fix carousel timestamp location for fallback message

b132fff


          minor fix

a60126e

chohongm added the v3.14.0 label

chohongm requested review from AhyoungRyu, HoonBaek and bang9

April 1, 2024 08:08

chohongm self-assigned this


          minor fix

ac604b5

bang9 reviewed

View reviewed changes

src/ui/TemplateMessageItemBody/types.ts Outdated Show resolved Hide resolved

bang9 reviewed

View reviewed changes

src/ui/TemplateMessageItemBody/types.ts Outdated Show resolved Hide resolved

bang9 reviewed

View reviewed changes

src/ui/MessageContent/index.tsx Outdated Show resolved Hide resolved

bang9 reviewed

View reviewed changes

src/ui/TemplateMessageItemBody/index.tsx Outdated Show resolved Hide resolved

bang9 reviewed

View reviewed changes

src/ui/TemplateMessageItemBody/index.tsx Outdated Show resolved Hide resolved

bang9 reviewed

View reviewed changes

src/ui/TemplateMessageItemBody/index.tsx Outdated Show resolved Hide resolved

bang9 reviewed

View reviewed changes

src/ui/TemplateMessageItemBody/index.tsx Outdated Show resolved Hide resolved

bang9 reviewed

View reviewed changes

src/ui/TemplateMessageItemBody/index.tsx Outdated Show resolved Hide resolved


          apply feeds

77462a2

chohongm changed the base branch from main to v3.14.0-beta-1

April 1, 2024 08:39

chohongm added 7 commits

April 1, 2024 17:45


          add error messages

8ca77f3


          use memo


          lint fix

a74a37e


          apply feeds

aa01637


          apply feeds

85b03c8


          fix error

e2124e0


          lint fix

b6d9ca2

bang9 approved these changes

View reviewed changes

chohongm merged commit de446c3 into v3.14.0-beta-1

chohongm deleted the feat/v3/AC-1230-support-carousel-template-with-simple-templates branch

April 1, 2024 10:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels