Skip to content

feat: Limit number of simple templates for carousel template. #1042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 5, 2024
Merged

feat: Limit number of simple templates for carousel template. #1042

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c00b19f
Limit number of simple templates for carousel template.
chohongm Apr 5, 2024
b2c87ae
naming update
chohongm Apr 5, 2024
bb064bb
Update src/ui/TemplateMessageItemBody/index.tsx
chohongm Apr 5, 2024
21d86cc
Update src/ui/TemplateMessageItemBody/index.tsx
chohongm Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/ui/TemplateMessageItemBody/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,11 +242,15 @@ export function TemplateMessageItemBody({
throw new Error('TemplateMessageItemBody | template key suggests composite template but template data is missing view_variables. See error log in console for details');
}
const reservationKey = removeAtAndBraces(carouselItem.items);
const simpleTemplateDataList: SimpleTemplateData[] | undefined = templateData.view_variables[reservationKey];
let simpleTemplateDataList: SimpleTemplateData[] | undefined = templateData.view_variables[reservationKey];
if (!simpleTemplateDataList) {
logger.error('TemplateMessageItemBody | no reservation key found in view_variables: ', reservationKey, templateData.view_variables);
throw new Error('TemplateMessageItemBody | no reservation key found in view_variables. See error log in console for details');
}
if (simpleTemplateDataList.length > 10) {
logger.warning('TemplateMessageItemBody | composite template with more than 10 simple templates will only render the first 10 items: ', reservationKey, templateData.view_variables);
simpleTemplateDataList = simpleTemplateDataList.slice(0, 10);
}
const { maxVersion, filledTemplates } = getFilledMessageTemplateItemsForCarouselTemplateByMessagePayload(
simpleTemplateDataList,
);
Expand All @@ -258,8 +262,13 @@ export function TemplateMessageItemBody({
items: filledTemplates,
}];
} else if (Array.isArray(carouselItem.items)) {
let simpleTemplates: SendbirdUiTemplate[] = carouselItem.items;
if (carouselItem.items.length > 10) {
logger.warning('TemplateMessageItemBody | composite template with more than 10 simple templates will only render the first 10 items: ', carouselItem);
simpleTemplates = carouselItem.items.slice(0, 10);
}
const { maxVersion, filledTemplates } = getFilledMessageTemplateItemsForCarouselTemplate(
carouselItem.items,
simpleTemplates,
);
result.isComposite = true;
result.templateVersion = Math.max(cachedTemplate.version, maxVersion);
Expand Down