Skip to content

Conversation

@bang9
Copy link
Contributor

@bang9 bang9 commented Apr 25, 2024

For Internal Contributors

  • Follow the Scaled Trunk-Based Development workflow(https://trunkbaseddevelopment.com/)
  • Branch naming format -> {type}/TICKET_ID/description
    • Where type = feat / feature / fix / chore / doc / release
  • Always receive PR review approvals
  • Rebase your branch with the main branch, and wait for CI to pass
  • Squash merge your commit
    • Follow the provided template for both the PR description and squashing to the main branch
    • Use imperative language in the title and description
    • The template is very similar to conventional commits. Read More

Template

// PR title (Required)
[type]: A short description of the changes in imperative language.

// Section: PR description (Optional)
Add a brief description of the changes that you have involved in this PR.
Bullet points are also fine.

// Section: Footer (Recommended)
// Recommended if you are dealing with SB_ISSUES (Customer issues) or release tickets.
Fixes: [<TICKET_ID>](https://sendbird.atlassian.net/browse/<TICKET_ID>)

// Section: Changelogs (Recommended)
// Add (internal) at the end of each changelog if internal. 
### Changelogs
- 

// If you want to add coauthors - for example, if you pair programmed or they made significant contributions to the ideas in the code and you want to thank them.
Co-authored-by: Name <name@example.com>, Name2 <name@example.com>

External Contributions

This project is not yet set up to accept pull requests from external contributors.

If you have a pull request that you believe should be accepted, please contact
the Developer Relations team developer-advocates@sendbird.com with details
and we'll evaluate if we can setup a CLA to allow for the contribution.

@bang9 bang9 self-assigned this Apr 25, 2024
@bang9 bang9 requested a review from chohongm April 25, 2024 08:08
Copy link
Contributor

@chohongm chohongm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@chohongm chohongm merged commit 1f99253 into feat/AC-1727-add-horizontal-scroll-on-suggested-replies Apr 26, 2024
chohongm pushed a commit that referenced this pull request Apr 30, 2024
chohongm pushed a commit that referenced this pull request Apr 30, 2024
@bang9 bang9 deleted the test/horizontal-scroll-view branch May 27, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants