Skip to content

Conversation

@bang9
Copy link
Contributor

@bang9 bang9 commented Nov 1, 2024

For Internal Contributors

  • Follow the Scaled Trunk-Based Development workflow
  • Branch naming format: {type}/TICKET_ID/description
    • Type: feat / fix / chore / doc / release
  • Receive PR review approvals
  • Rebase your branch with the main branch and wait for CI to pass
  • Squash merge your commit
    • Use imperative language in the title and description
    • Follow the provided template for PR description and squashing

Template

// PR title (Required)
[type]: A short description of the changes in imperative language.

// PR description (Optional)
Add a brief description of the changes in this PR. Bullet points are also fine.

// Footer (Recommended)
Fixes [<TICKET_ID>](https://sendbird.atlassian.net/browse/<TICKET_ID>)

// Changelogs (Recommended)
// Add (internal) at the end of each changelog if internal.
### Changelogs

// Co-authors
// Add this if you pair programmed or they made significant contributions to the ideas in the code and you want to thank them.
Co-authored-by: Name name@example.com, Name2 name@example.com

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If unsure, ask the members.
This is a reminder of what we look for before merging your code.

  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • Public components / utils / props are appropriately exported
  • I have added necessary documentation (if appropriate)

External Contributions

This project is not yet set up to accept pull requests from external contributors.

If you have a pull request that you believe should be accepted, please contact
the Developer Relations team developer-advocates@sendbird.com with details
and we'll evaluate if we can set up a CLA to allow for the contribution.

@bang9 bang9 self-assigned this Nov 1, 2024
@netlify
Copy link

netlify bot commented Nov 1, 2024

Deploy Preview for sendbird-uikit-react ready!

Name Link
🔨 Latest commit d3c5ee7
🔍 Latest deploy log https://app.netlify.com/sites/sendbird-uikit-react/deploys/672468a43bad9e0008d09ce8
😎 Deploy Preview https://deploy-preview-1244--sendbird-uikit-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bang9 bang9 force-pushed the chore/test-app-host branch from c9d67fa to d3c5ee7 Compare November 1, 2024 05:35
@bang9 bang9 changed the title chore: support regional base host for RQA chore: regional host support for RQA Nov 1, 2024
@bang9 bang9 merged commit 086f90a into main Nov 1, 2024
10 checks passed
@bang9 bang9 deleted the chore/test-app-host branch November 1, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants