Skip to content

Conversation

@sravan-s
Copy link
Contributor

@sravan-s sravan-s force-pushed the fix/UIKIT-1988/handler_proxy branch from 06b1646 to 5a0097d Compare August 11, 2022 07:55
Copy link
Contributor

@HoonBaek HoonBaek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just pls check some lint warnings before merge

@hronnro
Copy link

hronnro commented Aug 15, 2022

I think I might be stuck on this issue, I'm using v3.1.0 and I get Invalid Parameters error when I try to use GroupChannelHandler like shown in this example

Wondering if this PR is the fix I'm in the need of 👼 do you have ETA on merge? (no rush just curious)

@sravan-s
Copy link
Contributor Author

@hronnro We plan to release a RC today, sorry for the delay

@sravan-s sravan-s changed the title fix: export Handlers through sendbirdSelectors fix: export Handlers thorough react library Aug 16, 2022
@sravan-s sravan-s force-pushed the fix/UIKIT-1988/handler_proxy branch from 69a40d1 to a5e30c4 Compare August 16, 2022 04:24
@sravan-s sravan-s force-pushed the fix/UIKIT-1988/handler_proxy branch from a5e30c4 to f3abd8c Compare August 16, 2022 04:24
@sravan-s sravan-s changed the title fix: export Handlers thorough react library fix: export Handlers thorough uikit Aug 16, 2022
@sravan-s sravan-s merged commit 2e5f743 into main Aug 16, 2022
@sravan-s
Copy link
Contributor Author

sravan-s commented Aug 16, 2022

@hronnro https://codesandbox.io/s/test-3-1-1-rc-5-f94w7i
This version seems okay, so far, we will release 3.1.0 3.1.1 stable tomorrow after a bit more testing

sravan-s added a commit that referenced this pull request Aug 17, 2022
Handlers cannot seem to work  when imported through `@sendbird/chat`
fixes: https://sendbird.atlassian.net/browse/UIKIT-1993
sravan-s added a commit that referenced this pull request Aug 17, 2022
Handlers cannot seem to work  when imported through `@sendbird/chat`
fixes: https://sendbird.atlassian.net/browse/UIKIT-1993
@sravan-s sravan-s deleted the fix/UIKIT-1988/handler_proxy branch August 25, 2022 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants