[v3.1.1] (Aug 17 2022) #272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sravan-s
force-pushed
the
release/3.1.1_rc_0
branch
2 times, most recently
from
a13fcf6 to
52b490d
Compare
Features: * Add channel handlers to the open channel settings * Add an open channel handler into the OpenChannelSettings component * Use operators property to render operator list on the OpenChannelSetting instead of fetching operators Fixes: * Move @sendbird/uikit-react as build dependency, fixes GroupChannelHandlers failing to attach to SDK instance * Update SendableMessage to UserMessage and FileMessage * Change the type of MessageHandler.onFailed to FailedMessageHandler * Add missing type defns into scripts/index_d_ts * Typo in creating channelHandlerId on the ChannelList
sravan-s
force-pushed
the
release/3.1.1_rc_0
branch
from
52b490d to
12c1ec0
Compare
sravan-s
added a commit
that referenced
this pull request
Aug 17, 2022
Features: * Add channel handlers to the open channel settings * Add an open channel handler into the OpenChannelSettings component * Use operators property to render operator list on the OpenChannelSetting instead of fetching operators * Export handlers through `@sendbird/uikit-react/handlers`, this is a workaround to fix an issue where inhertiance chains break custom handler implementation * ConnectionHandler -> `@sendbird/uikit-react/handlers/ConnectionHandler` * GroupChannelHandler -> `@sendbird/uikit-react/handlers/GroupChannelHandler` * OpenChannelHandler -> `@sendbird/uikit-react/handlers/OpenChannelHandler` * UserEventHandler -> `@sendbird/uikit-react/handlers/UserEventHandler` * Example: https://codesandbox.io/s/test-3-1-1-rc-5-f94w7i Fixes: * Update SendableMessage to UserMessage and FileMessage * Change the type of MessageHandler.onFailed to FailedMessageHandler * Add missing type defns into scripts/index_d_ts * Typo in creating channelHandlerId on the ChannelList
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features:
instead of fetching operators
@sendbird/uikit-react/handlers, this is a workaroundto fix an issue where inhertiance chains break custom handler implementation
@sendbird/uikit-react/handlers/ConnectionHandler@sendbird/uikit-react/handlers/GroupChannelHandler@sendbird/uikit-react/handlers/OpenChannelHandler@sendbird/uikit-react/handlers/UserEventHandlerFixes: