[UK-973] Design change for message menu and status #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sravan-s
suggested changes
Oct 14, 2021
Contributor
sravan-s
left a comment
sravan-s
left a comment
There was a problem hiding this comment.
src/sendbird.min.js
shouldnt be here, right?
sravan-s
reviewed
Oct 14, 2021
sravan-s
reviewed
Oct 14, 2021
| &.menu-item-edit {} | ||
| &.menu-item-resend {} | ||
| &.menu-item-delete {} | ||
| } |
Contributor
There was a problem hiding this comment.
lets remove it when we merge to main
sravan-s
approved these changes
Oct 14, 2021
HoonBaek
deleted the
bugfix/UK-973/Design-change-for-message-menu-and-status
branch
HoonBaek
added a commit
that referenced
this pull request
Oct 25, 2021
* Add class names of MessageItemMenu * Change the message status design to row * Apply that replyTypeFilter is changed to replyType in core sdk * Add onLoad and onError props in ImageRenderer component * Change opacity and icon display of QuoteMessage * Move QuoteMessage into the MessageContent * Fix the center align of IconButton * Update core min.js file * Update snapshot * Update class name of menu items
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
External Contributions
This project is not yet set up to accept pull requests from external contributors.
If you have a pull request that you believe should be accepted, please contact
the Developer Relations team developer-advocates@sendbird.com with details
and we'll evaluate if we can setup a CLA to allow for the contribution.
For Internal Contributors
UK-973
Description Of Changes
Add a brief description of the changes that you have involved in this PR
Types Of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that apply_