Skip to content

Conversation

@HoonBaek
Copy link
Contributor

External Contributions

This project is not yet set up to accept pull requests from external contributors.

If you have a pull request that you believe should be accepted, please contact
the Developer Relations team developer-advocates@sendbird.com with details
and we'll evaluate if we can setup a CLA to allow for the contribution.

For Internal Contributors

QU-298

Description Of Changes

Fix typo of isReplyToChannel
Ignore '*' in the customTypes of messageListParams because it's inserted when customTypes array is empty by chat SDK.

Types Of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply_

  • Bugfix
  • New feature
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance (ex) Prettier)
  • Build configuration
  • Improvement (refactor code)

@HoonBaek HoonBaek requested a review from sravan-s October 26, 2021 00:41
@HoonBaek HoonBaek self-assigned this Oct 26, 2021
@HoonBaek HoonBaek requested a review from sravan-s October 26, 2021 01:52
Copy link
Contributor

@sravan-s sravan-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HoonBaek HoonBaek merged commit 1d1c489 into feature/UK-932/Integrate-message-threading Oct 26, 2021
@HoonBaek HoonBaek deleted the bugfix/QU-298/Fix-message-filter-issue branch October 26, 2021 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants