fix: Operate ephemeral channel #432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sravan-s
reviewed
Mar 7, 2023
src/smart-components/ChannelList/components/ChannelPreview/index.tsx
Outdated
Show resolved
Hide resolved
sravan-s
reviewed
Mar 9, 2023
| renderFileUploadIcon?: () => React.ReactElement; | ||
| renderVoiceMessageIcon?: () => React.ReactElement; | ||
| renderSendMessageIcon?: () => React.ReactElement; | ||
| renderFileUploadIcon?: () => React.ReactElement; |
sravan-s
reviewed
Mar 9, 2023
| declare module '@sendbird/uikit-react/ui/OpenChannelOGMessage' { | ||
| import type SenbirdUIKitGlobal from 'SendbirdUIKitGlobal'; | ||
| interface OOpenChannelOGMessageProps { | ||
| interface OpenChannelOGMessageProps { |
sravan-s
reviewed
Mar 9, 2023
|
|
||
| declare module '@sendbird/uikit-react/ui/OpenChannelUserMessage' { | ||
| import type SenbirdUIKitGlobal from 'SendbirdUIKitGlobal'; | ||
| import type SendbirdUIKitGlobal from 'SendbirdUIKitGlobal'; |
sravan-s
reviewed
Mar 9, 2023
Comment on lines
+143
to
+165
| (!channel?.isEphemeral && isMessageStatusEnabled) && ( | ||
| <MessageStatus | ||
| className="sendbird-channel-preview__content__upper__last-message-at" | ||
| channel={channel} | ||
| message={channel?.lastMessage as UserMessage | FileMessage} | ||
| isDateSeparatorConsidered={false} | ||
| /> | ||
| ) | ||
| } | ||
| { | ||
| (!channel?.isEphemeral && !isMessageStatusEnabled) && ( | ||
| <Label | ||
| className="sendbird-channel-preview__content__upper__last-message-at" | ||
| type={LabelTypography.CAPTION_3} | ||
| color={LabelColors.ONBACKGROUND_2} | ||
| > | ||
| {utils.getLastMessageCreatedAt({ | ||
| channel, | ||
| locale: dateLocale, | ||
| stringSet, | ||
| })} | ||
| </Label> | ||
| ) |
sravan-s
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Internal Contributors
UIKIT-3245
Ephemeral channel support - policy
Description Of Changes
Ephemeral channel policy
Types Of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that apply_