fix: Modify condition of checking parent and thread messages #466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sravan-s
reviewed
Mar 31, 2023
| return ( | ||
| message?.parentMessage !== null | ||
| && message?.parentMessageId !== null | ||
| && message?.parentMessageId |
Contributor
There was a problem hiding this comment.
add unit test before merge pls
Contributor
There was a problem hiding this comment.
If we're sure about its type is number and want to keep a strict way like before, you can do this too.
Suggested change
| && message?.parentMessageId | |
| && typeof message?.parentMessageId === 'number' // do we have this kind of util fcuntion? |
or
Suggested change
| && message?.parentMessageId | |
| && !isNaN(message?.parentMessageId) |
Contributor
Author
There was a problem hiding this comment.
It's sure that the type of parentMessaeId is number, so I wanted to check if it's 0 or more
sravan-s
approved these changes
Mar 31, 2023
HoonBaek
deleted the
fix/Modify-condition-of-checking-parent-and-thread-message
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes