Finalize message threading integration #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sravan-s
reviewed
Nov 2, 2021
sravan-s
reviewed
Nov 2, 2021
| allMessages: passUnsuccessfullMessages(state.allMessages, message), | ||
| }; | ||
| } | ||
| case actionTypes.ON_MESSAGE_UPDATED: { |
Contributor
There was a problem hiding this comment.
Add test for these two changes
Contributor
Author
There was a problem hiding this comment.
There is already a test for ON_MESSAGE_UPDATED event.
Let me add new tests for ON_MESSAGE_THREAD_INFO_UPDATED event.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Internal Contributors
QU-289
QU-299
QU-309
QU-336
Description Of Changes
customTypesof message list paramsTypes Of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that apply_