feature: Thread for mobile screen #530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AhyoungRyu
reviewed
May 11, 2023
sravan-s
reviewed
May 11, 2023
sravan-s
reviewed
May 11, 2023
sravan-s
reviewed
May 11, 2023
Comment on lines
+47
to
+48
| setStartingPoint?.(null); | ||
| setHighlightedMessage?.(null); |
Contributor
There was a problem hiding this comment.
Cleander would be to make these two fns. not nullable
ie: setStartingPoint(null); instead of setStartingPoint?.(null);
Contributor
There was a problem hiding this comment.
similar for other "local setters" than can be shared
Contributor
There was a problem hiding this comment.
from: setHighlightedMessage?: React.Dispatch<number | null>;
to: setHighlightedMessage: React.Dispatch<number | null>;
sravan-s
reviewed
May 11, 2023
Comment on lines
+10
to
+19
| .sb_mobile__panelwrap .sendbird-thread { | ||
| width: 100%; | ||
| height: 100%; | ||
| & .sendbird-thread-ui { | ||
| max-width: 100%; | ||
| & .sendbird-thread-ui__header { | ||
| width: 100%; | ||
| } | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
I guess this better be:
@include mobile() {
width: 100%;
}
Contributor
There was a problem hiding this comment.
Ideally, we have to imagine they should work flawlessly even when used independently (ie.outside App(Mobile)).. Given a proper container
sravan-s
approved these changes
May 19, 2023
Contributor
Author
|
I will apply the review in the separate PR |
HoonBaek
added a commit
that referenced
this pull request
May 19, 2023
### Description Of Changes * Apply MobileMenu/BottomSheet to the components: ParentMessageInfo and ThreadListItem * Apply the Thread module to the MobileLayout component * Add new Icon Thread [UIKIT-3476](https://sendbird.atlassian.net/browse/UIKIT-3476)
sravan-s
pushed a commit
that referenced
this pull request
Jun 1, 2023
For readability See: #530 (comment) Fixes: https://sendbird.atlassian.net/browse/UIKIT-4046
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
UIKIT-3476