Fix: Scroll towards top #547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HoonBaek
force-pushed
the
hot-fix/MessageList-scroll
branch
from
c844f2c to
b9cdc46
Compare
HoonBaek
approved these changes
May 19, 2023
HoonBaek
reviewed
May 19, 2023
Comment on lines
+54
to
+55
| // sets the scroll position to the top of the new messages | ||
| element.scrollTop = scrollTop - (scrollHeight - element.scrollHeight); |
There was a problem hiding this comment.
Oh, this is what I wanted to do 👍
HoonBaek
reviewed
May 19, 2023
Comment on lines
132
to
+133
| hasMore: hasMorePrev, | ||
| hasNext: hasMoreNext, |
There was a problem hiding this comment.
Could you leave a comment here?
like
// TODO: rename these two props, hasMore & hasNext
There was a problem hiding this comment.
Nah, let's do not that for now, I can make a fix after release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix scroll in MessageList
Debounce scroll events