fix: Race condition in playing audio file #608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Race condition occurs when two audio files are requested from backend Clear previous player and play only the last arrived file Cleanup - Do not need to fetch audio file if its already in cache
sravan-s
force-pushed
the
fix/UIKIT-3952/double_press
branch
from
37948b1 to
0ed66b8
Compare
sravan-s
commented
Jun 7, 2023
| resolve(audioFile); | ||
| logger.info('VoicePlayer: Use the audioFile instance.'); | ||
| resolve(audioFile); | ||
| return; |
Contributor
Author
There was a problem hiding this comment.
if there is audioFile, no need to fetch from backend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Race condition occurs when two audio files are requested from
backend clear previous player and play only the last arrived file
Cleanup - Do not need to fetch audio file if its already in cache
Fixes: https://sendbird.atlassian.net/browse/UIKIT-3952