feat: add sdkInitParams prop #692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sravan-s
approved these changes
Jul 21, 2023
sravan-s
approved these changes
Jul 21, 2023
Contributor
sravan-s
left a comment
sravan-s
left a comment
There was a problem hiding this comment.
Lets add example to commit mesage 👍
sravan-s
reviewed
Jul 21, 2023
| new OpenChannelModule(), | ||
| ], | ||
| newInstance: true, | ||
| ...sdkInitParams, |
Contributor
There was a problem hiding this comment.
undefined/null check necessary?
Also, probably we dont want to override appID
Contributor
Author
There was a problem hiding this comment.
Trying spread from undefined happens nothing actually but always better to be explicit :) a2f0541
Contributor
There was a problem hiding this comment.
hmmm have crashed on me once before(dont remember the env)
This was referenced Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://sendbird.atlassian.net/browse/AC-217
Currently, there's no way to customize
sdk.init()parameters outside of UIKit since sdk.init() is called internally within UIKit.So I'm going to add a new prop called sdkInitParams that allows passing custom parameters from outside of UIKit(e.g. chat-ai-widget).
Then user will be able to pass any
SendbirdChatParamslisted in https://sendbird.com/docs/chat/v4/javascript/ref/interfaces/_sendbird_chat.SendbirdChatParams.html viasdkInitParams.