fix: Apply metadata to the ChannelListQuery #723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to the Channel.queries.channelListQuery
AhyoungRyu
approved these changes
Sep 1, 2023
HoonBaek
deleted the
fix/CLNP-687/Apply-metadata-to-channel-list-query-filter
branch
chohongm
reviewed
Sep 1, 2023
| return false; | ||
| } | ||
| if (params?.customTypesFilter?.length > 0 && !params.customTypesFilter.includes(channel?.customType)) { | ||
| if (customTypesFilter && !customTypesFilter.includes(channel?.customType)) { |
Contributor
There was a problem hiding this comment.
maybe better to do:
typeof customTypesFilter === 'array'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
There was an issue report that some of the ChannelListQuery properties are not applied even though they are set.
A customer set the metadataKey and metadataValues, but we have not applied the filter props.
Fix
fix: apply metadataKey, metadataValues, and metadataStartsWith to the Channel.queries.channelListQuery
How to use
CLNP-687