fix: precise object dependency in effect hook #831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AhyoungRyu
force-pushed
the
fix/precies-object-dep
branch
from
7a23206 to
f8135b7
Compare
chohongm
pushed a commit
that referenced
this pull request
Nov 6, 2023
Put more precise `queries(: object)` deps to effect hook to prevent unnecessary re-rendering from Channel module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found the issue while I was testing https://sendbird.atlassian.net/browse/SBISSUE-14025.
If user passes custom
queries(: object)prop to Channel module, it'll cause unnecessary re-rendering in this effect hook. So I just made it more precise so the deps array don;t waste the resource to compare the object diff and make unnecessary side effect.