Skip to content

fix: Include metaArray to messages when reconnecting #897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 15, 2023
Merged

fix: Include metaArray to messages when reconnecting #897

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
838c2cb
Include metaArray to the message list when fetching messages again by…
HoonBaek Dec 15, 2023
6f3a93d
fix lint error
HoonBaek Dec 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/hooks/VoicePlayer/useVoicePlayer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,12 @@ export const useVoicePlayer = ({
play: playVoicePlayer,
pause: pauseVoicePlayer,
stop: stopVoicePlayer,
playbackTime: currentAudioUnit.playbackTime * 1000,
duration: currentAudioUnit.duration * 1000,
// the unit of playbackTime and duration should be millisecond
/**
* The reason why we multiply this by *1000 is,
* The unit of playbackTime and duration should be millisecond
*/
playbackTime: (currentAudioUnit?.playbackTime || 0) * 1000,
duration: (currentAudioUnit?.duration || 0) * 1000,
playingStatus: currentAudioUnit.playingStatus,
});
};
1 change: 0 additions & 1 deletion src/lib/hooks/useOnlineStatus.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ function useOnlineStatus(sdk: SendbirdChat, logger: LoggerInterface) {
onReconnectStarted() {
setIsOnline(false);
logger.warning('onReconnectStarted', { isOnline });

},
onReconnectSucceeded() {
setIsOnline(true);
Expand Down
1 change: 1 addition & 0 deletions src/modules/Channel/context/hooks/useHandleReconnect.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ function useHandleReconnect(
prevResultSize: PREV_RESULT_SIZE,
isInclusive: true,
includeReactions: isReactionEnabled,
includeMetaArray: true,
nextResultSize: NEXT_RESULT_SIZE,
};
if (replyType && replyType === 'QUOTE_REPLY') {
Expand Down