[UK-859] Use this repo as the primary one #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sravan-s
force-pushed
the
feat/UK-859/merge-repos
branch
from
81b83d1 to
08b9cc3
Compare
sravan-s
changed the title
sravan-s
force-pushed
the
feat/UK-859/merge-repos
branch
from
08b9cc3 to
4b7638e
Compare
HoonBaek
approved these changes
Aug 26, 2021
| # to do: index.css cannot be bundled into ./dist using rollup.json | ||
| # Also, rollup-copy is not working synchronously | ||
| # Solution - for v3, we should change the bundling position/import of CSS | ||
| mkdir dist |
Contributor
There was a problem hiding this comment.
why make directory 'dist' here? I think it's already made by rollup-c. no?
Contributor
Author
There was a problem hiding this comment.
It doesn't :( There are better ways to solve this, lets do it for v3.
sravan-s
force-pushed
the
feat/UK-859/merge-repos
branch
from
4b7638e to
5acd906
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, we had internal repos for development and release
From now on, we will be developing here
Work done: