Skip to content

Conversation

@HoonBaek
Copy link
Contributor

@HoonBaek HoonBaek commented Jan 11, 2024

Issue

SBISSUE-14550
We've used display: inline-block inside of the Badge and Button.
But it breaks the center alignment in the FireFox browser, so need to change to using display: inline-flex and add more properties for center alignment

Fix

  • Apply the center alignment to the Badge and Button components (in FireFox)

Changelog

  • Fixed a bug where center alignment of Badge and Button components breaking in FireFox browser

@HoonBaek HoonBaek self-assigned this Jan 11, 2024
Copy link
Contributor

@chohongm chohongm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chohongm chohongm merged commit a9017a9 into main Jan 19, 2024
@chohongm chohongm deleted the fix/CLNP-1914/Center-align-of-Badge-and-Button branch January 19, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants