Update WebRTC version to m103 #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
media_kind is the old name (that is kept around since we can't deprecate) BUG=None Change-Id: I445441a54bb4ff408502d1aba6834cdac874324b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259766 Reviewed-by: Henrik Boström <hbos@webrtc.org> Reviewed-by: Artem Titov <titovartem@webrtc.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/main@{#36625}
This is a reland of commit 8088aad Patchset 1 is original CL, patchset 2 contains a fix to make behavior exactly identical to original. It fixes a difference when the first small probe packet comprises the entire probe. Original change's description: > Send first probe packet directly instead of enqueuing it. > > This avoids potentially creating needless containers in the packet > queue and removes usage of the packet prio, allowing it to be moved in > an upcoming CL. > > Bug: webrtc:11340 > Change-Id: Iddd9e7e4e73c97ab25a85e42bcc0094d61fd60d3 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259524 > Reviewed-by: Emil Lundmark <lndmrk@webrtc.org> > Commit-Queue: Erik Språng <sprang@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#36602} Bug: webrtc:11340 Change-Id: I7d2f476a7043edd03f44a4a3de31f13c3c946a8d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259776 Reviewed-by: Emil Lundmark <lndmrk@webrtc.org> Commit-Queue: Erik Språng <sprang@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36626}
Bug: webrtc:9838 Change-Id: Ia5a45291a403097c0527d50ced85c3881653fa37 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259306 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36627}
… it."" This reverts commit fc5871c. Reason for revert: I rage quit. Original change's description: > Reland "Send first probe packet directly instead of enqueuing it." > > This is a reland of commit 8088aad > > Patchset 1 is original CL, patchset 2 contains a fix to make behavior > exactly identical to original. It fixes a difference when the first > small probe packet comprises the entire probe. > > Original change's description: > > Send first probe packet directly instead of enqueuing it. > > > > This avoids potentially creating needless containers in the packet > > queue and removes usage of the packet prio, allowing it to be moved in > > an upcoming CL. > > > > Bug: webrtc:11340 > > Change-Id: Iddd9e7e4e73c97ab25a85e42bcc0094d61fd60d3 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259524 > > Reviewed-by: Emil Lundmark <lndmrk@webrtc.org> > > Commit-Queue: Erik Språng <sprang@webrtc.org> > > Cr-Commit-Position: refs/heads/main@{#36602} > > Bug: webrtc:11340 > Change-Id: I7d2f476a7043edd03f44a4a3de31f13c3c946a8d > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259776 > Reviewed-by: Emil Lundmark <lndmrk@webrtc.org> > Commit-Queue: Erik Språng <sprang@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#36626} Bug: webrtc:11340 Change-Id: Ife22cff8f5fbf9b70dc24926b84caad82d2738b8 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259778 Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Erik Språng <sprang@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36628}
Bug: webrtc:9838 Change-Id: I14feff7b1f0182d031b6644d281be44122820ce7 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259307 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36629}
Bug: None Change-Id: If75c7063e137ec72968bcb19d22c432056196569 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259900 Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com> Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#36630}
https://webrtc-review.googlesource.com/c/src/+/259457 was a cherry-pick to M102; as such changes were not made there to keep the merge to just what had already landed. This addresses the issues raised on that CL. Bug: chromium:1316478 Change-Id: I94fad0aa6fe9c67aee5a2f2158524d75b51db48e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259660 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36631}
Bug: webrtc:9838 Change-Id: I472223685b15c46cd351fd6d9ddec837d898a0db Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259308 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36632}
Bug: webrtc:9838 Change-Id: Ieb2fbaad8831439ca04fc5249e295c8839f6890e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259309 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36633}
Bug: webrtc:9838 Change-Id: Ic7e912cba1218f1eed794cb8c393ac148106b16c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259310 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36634}
Bug: None Change-Id: I6f710e1d701a50e37d88951365b18d03fad07437 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259920 Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com> Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#36635}
Bug: webrtc:9838 Change-Id: Ib9a9cd3bc868e716315594c436df7e2cce0d9a5a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259311 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36636}
Bug: webrtc:9838 Change-Id: Ic3c424729b5edd3e378c4195afe33ae5c88ad491 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259312 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36637}
Return a copy of the frames counters to be able to get DVQA stats while it is running. Bug: b/213863770 Change-Id: I04755117cf363e1f160caa11dbe52fb30324fdf5 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259867 Reviewed-by: Andrey Logvin <landrey@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36638}
Bug: None Change-Id: I1e991c26e5c7582ade33f8895688c8f146bcd459 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259980 Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com> Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#36639}
This reverts commit f0a34f2. Reason for revert: Fixed downstream projects to not require those fields. Original change's description: > Revert "remove mslabel and mslabel ssrc-specific attributes" > > This reverts commit e3f257c. > > Reason for revert: Breaks downstream projects > > Original change's description: > > remove mslabel and mslabel ssrc-specific attributes > > > > Removes support for parsing and serializing > > a=ssrc:1 mslabel:stream > > a=ssrc:1 label:track > > which have been superceeded by > > a=ssrc:1 msid:stream track > > a long time ago. > > > > Bug: webrtc:7110 > > Change-Id: I3aca47728098b6e7e049b82ed34c59426d411c41 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/168244 > > Commit-Queue: Harald Alvestrand <hta@webrtc.org> > > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > > Reviewed-by: Kári Helgason <kthelgason@webrtc.org> > > Cr-Commit-Position: refs/heads/master@{#30801} > > TBR=kthelgason@webrtc.org,hta@webrtc.org,philipp.hancke@googlemail.com > > Change-Id: Ibd0ad11d2dee9f54bacab3dcca61dedccfc2c120 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: webrtc:7110 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170620 > Reviewed-by: Artem Titov <titovartem@webrtc.org> > Commit-Queue: Artem Titov <titovartem@webrtc.org> > Cr-Commit-Position: refs/heads/master@{#30805} Change-Id: Iec4bd460b35ce49cdb03dd607d2c8b1dee6210ab Bug: webrtc:7110 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/170622 Reviewed-by: Philipp Hancke <philipp.hancke@googlemail.com> Reviewed-by: Henrik Boström <hbos@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36640}
This avoids potentially creating structures in the queue, and removes usage of a special priority class enabling us to move priority handling in a follow-up. Bug: webrtc:11340 Change-Id: I2286ef6eac62e1d6dd89f6eb6035b23f27543d8a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259960 Reviewed-by: Emil Lundmark <lndmrk@webrtc.org> Commit-Queue: Erik Språng <sprang@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36641}
It seems like this got confused when initially added [1,2]. The confusion affects the lag check [3], which only send an email in the past, but will raise a builder failure after [4] landed if there is a gap for more than 4 commits. [1] https://crsrc.org/i/infra/services/lkgr_finder/config/default_cfg.pyl?q=allowed_gap [2] https://crsrc.org/i/infra/services/lkgr_finder/test/lkgr_lib_test.py?q=allowed_gap [3] https://crsrc.org/i/infra/services/lkgr_finder/lkgr_lib.py;l=500?q=allowed_lag [4] https://crrev.com/c/3599253 Bug: chromium:1317669 Change-Id: I23726957439b03dced0fc0038ee65a3108f88fea Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259874 Auto-Submit: Alex Schulze <alexschulze@google.com> Reviewed-by: Christoffer Jansson <jansson@webrtc.org> Commit-Queue: Christoffer Jansson <jansson@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36642}
Bug: webrtc:9838 Change-Id: Ibd0199803597eff48ca139a5cecdc3209c62c5d2 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259873 Auto-Submit: Florent Castelli <orphis@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36643}
This will simplify upcoming changes to the queue. Bug: webrtc:11340 Change-Id: Id023618fdef8a8bc9fb50e477cc87e6ba20c5421 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259875 Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Commit-Queue: Erik Språng <sprang@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36644}
Use rtc::scoped_refptr to keep object pointers valid Bug: webrtc:13993 Change-Id: Iffb6bf47e97606bfa3c2e9d8814a56cf509abbd6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259940 Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36645}
Types with ToLogString implemented were not being recognized correctly. Now types like TimeDelta and Timestamp can be logged as normal. Change-Id: Ia15f90bdd1d63a39f7452f9b4bba178d01b74352 Bug: webrtc:13995 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/259863 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Evan Shrubsole <eshr@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36646}
This is the first step in the next refactoring: 1. Make general peer params immutable and accessible only via const ref. 2. Extract params which can be changed during the call 3. Expose mutators for mutable params protecting them with proper locking. Bug: b/213863770 Change-Id: Ie3ac17918f1fed3b8ec84992f8b0afc402bce7f4 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260003 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36647}
Bug: None Change-Id: Icd5abef1712d815db40f9a293b1acda2c7289eb0 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260080 Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com> Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#36648}
A target with only header files should be a source_set. Bug: webrtc:9838, chromium:1319559 Change-Id: Ic60ed3ac074c36bee0a16831cd463053a7d81efe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260043 Auto-Submit: Florent Castelli <orphis@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36649}
In the referenced ticket, we changed the allowed_lag from 40h to 90h (for low volume commit periods) to survive weekends without succeeding builders. This rolls the change into WebRTC, and removes a duplicated builder entry. Bug: chromium:1317669 Change-Id: Ife9dd6ff119948ffbd0fa92c7d59466d31ebb215 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260040 Auto-Submit: Alex Schulze <alexschulze@google.com> Reviewed-by: Christoffer Jansson <jansson@webrtc.org> Commit-Queue: Christoffer Jansson <jansson@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36650}
Also remove tests in //tools_webrtc/mb/mb_unittest.py that are testing exclusively code in //tools/mb/mb.py. Bug: webrtc:13662 Change-Id: Ifdfbe26c11f7c315e307856b1d3ab06483d57641 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260041 Reviewed-by: Björn Terelius <terelius@webrtc.org> Commit-Queue: Jeremy Leconte <jleconte@google.com> Cr-Commit-Position: refs/heads/main@{#36651}
Bug: chromium:1199405 Change-Id: I0a0ca56b217760cba0db6b1a8b1580bea0edc6a5 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260103 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Christoffer Jansson <jansson@webrtc.org> Commit-Queue: Jeremy Leconte <jleconte@google.com> Cr-Commit-Position: refs/heads/main@{#36652}
Change log: https://chromium.googlesource.com/chromium/src/+log/cf02a445ae..2fafc86d5a Full diff: https://chromium.googlesource.com/chromium/src/+/cf02a445ae..2fafc86d5a Changed dependencies * src/base: https://chromium.googlesource.com/chromium/src/base/+log/d77eef57aa..ad6a819bf0 * src/build: https://chromium.googlesource.com/chromium/src/build/+log/ee629c68f3..13e929691f * src/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/c2e4795660..f0d740e4e2 * src/buildtools/linux64: git_revision:1cdd270be9803dbfcdd0343f6104ad4dc30c38ce..git_revision:d0f8bc99e0584cd33ea8030441d58ee875af7842 * src/buildtools/mac: git_revision:1cdd270be9803dbfcdd0343f6104ad4dc30c38ce..git_revision:d0f8bc99e0584cd33ea8030441d58ee875af7842 * src/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/e025ba5dc8..7d9bbeb389 * src/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/1acfbbb474..fe26c4b100 * src/buildtools/win: git_revision:1cdd270be9803dbfcdd0343f6104ad4dc30c38ce..git_revision:d0f8bc99e0584cd33ea8030441d58ee875af7842 * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/6641fa07bf..741fa9bbdb * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/272a3d1c86..338ce53949 * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/b109108029..fddac3310a * src/third_party/android_build_tools/aapt2: u2Cw4baoLfvlEDMwcJjq9iOJRF0_2BjsgMFl7UhJxGAC..RDutOGK_MVVg63biRaUn8n43zaISYedSEtTJAw-gSegC * src/third_party/android_build_tools/bundletool: zQILIUnCaQ93HTtR07m4ahlE9mrkkwks52L5vFaUaUUC..AqsPZpWJh-ZyGraHKlbH8XgjRnmyDmolX4HhwPEo9XUC * src/third_party/androidx: 4144ITIgXUisP3mBnV8td3mdaIKKku5UW_bQjgoP9r8C..k4t_4yTm03LpWgvtVabkki_hjYZ0-R6vK2R68XEEKFwC * src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/edbdc240ec..6686352e49 * src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/c7b6e53b40..820618f8e6 * src/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/89ccf4a805..7feb245cf5 * src/third_party/freetype/src: https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/079a22da03..581dd06405 * src/third_party/harfbuzz-ng/src: https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+log/903cf8cfce..6454cec085 * src/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu.git/+log/d2858cb5ee..5fb93cb43c * src/third_party/perfetto: https://android.googlesource.com/platform/external/perfetto.git/+log/623889d7db..bbe5831b28 * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/2df27a463e..9e0d2003d8 * src/tools/luci-go: git_revision:6da0608e4fa8a3c6d1fa4f855485c0038b05bf72..git_revision:2aa3d7e5e8662c5193059a490f07b7d91331933e * src/tools/luci-go: git_revision:6da0608e4fa8a3c6d1fa4f855485c0038b05bf72..git_revision:2aa3d7e5e8662c5193059a490f07b7d91331933e DEPS diff: https://chromium.googlesource.com/chromium/src/+/cf02a445ae..2fafc86d5a/DEPS Clang version changed llvmorg-15-init-7570-gba4537b2:llvmorg-15-init-8609-g3254f468 Details: https://chromium.googlesource.com/chromium/src/+/cf02a445ae..2fafc86d5a/tools/clang/scripts/update.py BUG=None remove chromium/third_party/android_sdk/public/extras Change-Id: I8261d7b622dd8a8010835c0ad266e1f1856ae671 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260102 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Christoffer Jansson <jansson@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36653}
Change-Id: I1c8fabe5caf2c723487ec1cd71a379e922026a9d Bug: webrtc:13996 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/260001 Reviewed-by: Erik Språng <sprang@webrtc.org> Commit-Queue: Evan Shrubsole <eshr@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36654}
…ens. The change bounds the estimate increment by MaxIncreaseFactor in DelayedIncreaseWindow after seeing loss. MaxIncreaseFactor is set to 1000 to disable the change by default. Improve trendline integration: always allow to decrease the estimate, and only allow to increase the estimate if overusing and underusing are not in the state window. Other improvement: bound candidates by delay based estimate, instance upper bound, and bandwidth limit in the current window. Clean: remove the flag BackoffWhenOverusing since it has negative impacts when experimenting. Bug: webrtc:12707 Change-Id: Ia4c1e58d692071967e8807a8b9d64b8ae4caf837 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261240 Reviewed-by: Per Kjellander <perkj@webrtc.org> Commit-Queue: Diep Bui <diepbp@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36847}
This is in preparation for adding a portal / pipewire backend. This just renames one class and moved the code to different files. There are no changes to the implementation. Bug: webrtc:13177 Change-Id: Iae101fcabafdb6cddd4d82adbb26219e4b37557f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261680 Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Reviewed-by: Per Kjellander <perkj@webrtc.org> Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36848}
- Filter out very old packets (to ensure that the estimate doesn't drop to zero if sending is paused and later resumed). - Discard packets older than previously discarded packets (to avoid the estimate dropping after deep reordering.) - Add tests cases for high loss, deep reordering and paused/resumed streams to unittest. - Remove some field trial settings that have very minor effect and rename some of the others. - Change analyzer.cc to only draw data points if the estimators have valid estimates. Bug: webrtc:13402 Change-Id: I47ead8aa4454cced5134d10895ca061d2c3e32f4 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/236347 Commit-Queue: Björn Terelius <terelius@webrtc.org> Reviewed-by: Per Kjellander <perkj@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36849}
This was found during code review. This code is essentially dead code until interleaved messaging is implemented, which is disabled both in configuration and due to missing code. Bug: None Change-Id: Idea87dfe2be204361774d8964140fd9947a66410 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261944 Commit-Queue: Victor Boivie <boivie@webrtc.org> Reviewed-by: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36850}
Change log: https://chromium.googlesource.com/chromium/src/+log/6d6259fea9..ed828a5477 Full diff: https://chromium.googlesource.com/chromium/src/+/6d6259fea9..ed828a5477 Changed dependencies * src/base: https://chromium.googlesource.com/chromium/src/base/+log/88efeaa992..27f8abf71a * src/buildtools/linux64: git_revision:bf4e17dc67b2a2007475415e3f9e1d1cf32f6e35..git_revision:578a7fe4c3c6b0bc2ae1fd2e37f14857d09895bf * src/buildtools/mac: git_revision:bf4e17dc67b2a2007475415e3f9e1d1cf32f6e35..git_revision:578a7fe4c3c6b0bc2ae1fd2e37f14857d09895bf * src/buildtools/win: git_revision:bf4e17dc67b2a2007475415e3f9e1d1cf32f6e35..git_revision:578a7fe4c3c6b0bc2ae1fd2e37f14857d09895bf * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/0890387867..769482653f * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/e2bae8d634..b363f6a41f * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/25e5903bcd..871459b1cf * src/third_party/androidx: vZNvIbZD3QeeHd82_9LRcLzoETy5YzBKbA7bV5MXBBAC..N11h90BOkwT_ErtH-6ZmLb5ptpWC7xllgXt3TDEphj0C * src/third_party/perfetto: https://android.googlesource.com/platform/external/perfetto.git/+log/a942004e95..fbdedcfb33 * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/4ef2956fcb..1288a08a71 DEPS diff: https://chromium.googlesource.com/chromium/src/+/6d6259fea9..ed828a5477/DEPS No update to Clang. BUG=None Change-Id: Icdb1059a04499fdac179d1e51482a5a2abe31ac9 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262041 Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#36851}
Since the lifetime of an SctpDataChannel is not strictly controlled by its controller, the controller might go away before the channel does. This CL guards against this. Bug: webrtc:13931 Change-Id: I07046fe896d1a66bf89287429beb0587382a13a9 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261940 Commit-Queue: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36852}
Define a local function in the only place where it is used, for calling SSL_set1_curves_list. Bug: webrtc:6424 Change-Id: I7b9c372aaed15dbc88ced55652f5afd93db55e49 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261313 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36853}
Change log: https://chromium.googlesource.com/chromium/src/+log/ed828a5477..598b93304b Full diff: https://chromium.googlesource.com/chromium/src/+/ed828a5477..598b93304b Changed dependencies * src/base: https://chromium.googlesource.com/chromium/src/base/+log/27f8abf71a..1fb3d1d730 * src/buildtools/third_party/libunwind/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/3d54d41c27..3e0d3ec585 * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/769482653f..78de2e463b * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/b363f6a41f..1295d94c88 * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/871459b1cf..655473b8ac * src/third_party/androidx: N11h90BOkwT_ErtH-6ZmLb5ptpWC7xllgXt3TDEphj0C..9EARqDo1HNj2IE6F5pbKWOUSN2acBpBu04AW3SP7qAEC * src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/735a86834c..227ff6e642 * src/third_party/openh264/src: https://chromium.googlesource.com/external/github.com/cisco/openh264/+log/b52786888d..fac04ceb3e * src/third_party/perfetto: https://android.googlesource.com/platform/external/perfetto.git/+log/fbdedcfb33..1de2530cbb * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/1288a08a71..e3a84ba077 DEPS diff: https://chromium.googlesource.com/chromium/src/+/ed828a5477..598b93304b/DEPS No update to Clang. BUG=None Change-Id: Ic3c1dcc7ad8fc9b095f8043a1a9d7fc46dc11c4e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262100 Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#36854}
Apple renamed CGColorSpaceCopyICCProfile to CGColorSpaceCopyICCData in 10.13. If you compile code with a minimum OS required of 10.13 or newer, [-Werror,-Wdeprecated-declarations] will cause an error to occur on use of the function with the old name. Add a compile switch so that no error is emitted regardless of the deployment configuration. Bug: chromium:1322548 Change-Id: Ie969aa9e5c4fc9bee2ec88b126d4c07701c3e9e6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261953 Reviewed-by: Mark Foltz <mfoltz@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/main@{#36855}
This allows builds on non-x86 architectures such as ppc64el. Bug: webrtc:14057 Signed-off-by: Timothy Pearson <tpearson@raptorcs.com> Change-Id: Ie2c1023d2c1d041ba1d140f06af432ed9e9f7432 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262002 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by: Mark Foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/main@{#36856}
Change log: https://chromium.googlesource.com/chromium/src/+log/598b93304b..93c32ed01f Full diff: https://chromium.googlesource.com/chromium/src/+/598b93304b..93c32ed01f Changed dependencies * src/base: https://chromium.googlesource.com/chromium/src/base/+log/1fb3d1d730..a58e181148 * src/build: https://chromium.googlesource.com/chromium/src/build/+log/1c34f36484..8c1118a6ba * src/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/ecff200716..bb1e46cb72 * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/78de2e463b..ff224ae111 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/1295d94c88..663fe5ea6e * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/655473b8ac..13f944fa3f * src/third_party/androidx: 9EARqDo1HNj2IE6F5pbKWOUSN2acBpBu04AW3SP7qAEC..2V7ZDLIKJDlBnGSSJXQDu9ZmBIHGqJzUGaNLc9A8nkoC * src/third_party/perfetto: https://android.googlesource.com/platform/external/perfetto.git/+log/1de2530cbb..4786303513 * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/e3a84ba077..06c7fa81ae DEPS diff: https://chromium.googlesource.com/chromium/src/+/598b93304b..93c32ed01f/DEPS No update to Clang. BUG=None Change-Id: I4e76abb55cd4627e20bb143bcd74780b7c55e5cc Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262141 Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#36857}
HandleXEvent() returns true to indicate the event is consumed and should not be passed to other registered handlers of the same event-type. In ScreenCapturerX11, this makes sense for XDamage events because they are scoped to the object's |damage_handle_|. But RRScreenChangeNotify and ConfigureNotify events are scoped to the root window, so this CL changes the return value to false for these events. This allows other handlers (including other screen-capturer instances) to see these events. Bug: webrtc:14060 Change-Id: Id18917b0b62d125da08578e08df9648062500cad Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262142 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/main@{#36858}
Bug: None Change-Id: Ied41819bce6f0224dce4596d26e4f621c7923dd9 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262083 Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com> Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#36859}
Change log: https://chromium.googlesource.com/chromium/src/+log/93c32ed01f..4316df7fb4 Full diff: https://chromium.googlesource.com/chromium/src/+/93c32ed01f..4316df7fb4 Changed dependencies * src/base: https://chromium.googlesource.com/chromium/src/base/+log/a58e181148..7b99d25397 * src/build: https://chromium.googlesource.com/chromium/src/build/+log/8c1118a6ba..cde1f18128 * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/ff224ae111..7b6b399ff3 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/663fe5ea6e..4a1e43770a * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/13f944fa3f..7458013180 * src/third_party/android_build_tools/aapt2: RDutOGK_MVVg63biRaUn8n43zaISYedSEtTJAw-gSegC..kZqQH92bSO1p0a7_hcrana_9YjtSBU1te7TEtNVBoCUC * src/third_party/androidx: 2V7ZDLIKJDlBnGSSJXQDu9ZmBIHGqJzUGaNLc9A8nkoC..hBgSeEmZ8GuP4BLyiCIFTDSRneDoyni6mk1go9MHX_IC * src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/d1ddc12119..e9b5526658 * src/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/31bfd51995..9997ceb9a1 * src/third_party/jsoncpp/source: https://chromium.googlesource.com/external/github.com/open-source-parsers/jsoncpp.git/+log/9059f5cad0..42e892d96e * src/third_party/libunwindstack: https://chromium.googlesource.com/chromium/src/third_party/libunwindstack.git/+log/6868358481..3c86843ae0 * src/third_party/perfetto: https://android.googlesource.com/platform/external/perfetto.git/+log/4786303513..14feb31190 * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/06c7fa81ae..74d04d57dc DEPS diff: https://chromium.googlesource.com/chromium/src/+/93c32ed01f..4316df7fb4/DEPS No update to Clang. BUG=None Change-Id: I9511e869039c824e50207ac8bb03691cc8c20bf8 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261927 Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#36860}
Bug: webrtc:13579 Change-Id: I01b7a2e20b7ff976aa50f7dd068431eb288e6fae Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261904 Reviewed-by: Ali Tofigh <alito@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Niels Moller <nisse@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36861}
By calling release() the ref counter is not decremented and when the observer is later wrapped in a scoped_refprt its counter will be 2 instead of 1, leading to a memory leak. Bug: b/231912631 Change-Id: I466e5c29ba4f4aee43e8cf23f2e04fa4b6351b4c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261954 Reviewed-by: Artem Titov <titovartem@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36862}
Bug: b/232293787 Change-Id: I7f781ff38a23ae829447e5274ec7f6493de8195d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262240 Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Emil Lundmark <lndmrk@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36863}
Similar mocks are used internally, there should only be one in WebRTC. Bug: None Change-Id: Ic5163ae0c554c602344a0d25d17c3f0d46fc2e95 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261955 Auto-Submit: Florent Castelli <orphis@webrtc.org> Reviewed-by: Niels Moller <nisse@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36864}
VideoSimulcastConfig::encoding_params and VideoConfig::min/max_encode_bitrate_bps were replaced by VideoConfig::encoding_params. All usage of the previous options has been updated to the new option. Bug: webrtc:11607 Change-Id: I52cd9efa6e640929485da7aa1e61d15a1a693b1d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261949 Reviewed-by: Artem Titov <titovartem@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36865}
Change log: https://chromium.googlesource.com/chromium/src/+log/4316df7fb4..bca1174cd5 Full diff: https://chromium.googlesource.com/chromium/src/+/4316df7fb4..bca1174cd5 Changed dependencies * src/base: https://chromium.googlesource.com/chromium/src/base/+log/7b99d25397..86e89d2f5c * src/build: https://chromium.googlesource.com/chromium/src/build/+log/cde1f18128..08c3a4a86e * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/7b6b399ff3..9774f8152d * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/4a1e43770a..947e3a4e8a * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/7458013180..6a087b22ff * src/third_party/androidx: hBgSeEmZ8GuP4BLyiCIFTDSRneDoyni6mk1go9MHX_IC.._6LSpTMrwppYMyP7cQHuhfab0hq8aJFpArKyFPpd9wgC * src/third_party/freetype/src: https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/e8ebfe988b..5d49473f85 * src/third_party/perfetto: https://android.googlesource.com/platform/external/perfetto.git/+log/14feb31190..b3694fd901 * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/74d04d57dc..685f074707 DEPS diff: https://chromium.googlesource.com/chromium/src/+/4316df7fb4..bca1174cd5/DEPS No update to Clang. BUG=None Change-Id: If82a3256851eb3aca78498a2e499d7448627738e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262280 Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#36866}
Bug: chromium:1324120 Change-Id: Ie609da309427ca5d2ff8585a8dc730586553c725 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262247 Auto-Submit: Markus Handell <handellm@webrtc.org> Commit-Queue: Markus Handell <handellm@webrtc.org> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Commit-Queue: Ilya Nikolaevskiy <ilnik@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36867}
No-try: true Bug: none Change-Id: Iea776ac43a6a0d83cce2bc9e10535213890bfce0 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/261948 Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org> Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Cr-Commit-Position: refs/heads/main@{#36868}
This will be used as a fall-back when the encoder adapter doesn't provide any dependency structure. This ensures we can always generate a dependency descriptor RTP header extension for VP8. Before, when switching between encoder adapters where the old one generated a dependency structure but the new one didn't we had to make sure the structure was cleared so that packets weren't sent with the dependency structure from the previous adapter. This will not be a problem anymore since the new adapter will use the simulated dependency structure. (cherry picked from commit 6c81a42) Bug: b/227749056, chromium:1328026 Change-Id: I8463c48a9dcde4b8d32c519819dd8a92acd8e43b No-Presubmit: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262765 Commit-Queue: Emil Lundmark <lndmrk@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Cr-Original-Commit-Position: refs/heads/main@{#36930} Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264547 Reviewed-by: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/branch-heads/5060@{#1} Cr-Branched-From: 1389c76-refs/heads/main@{#36868}
This allows for its use in test targets in Chromium Windows, which fixes the compiled errors found in https://chromium-review.googlesource.com/c/chromium/src/+/3649679 (cherry picked from commit 5b8dc1d) Change-Id: I738b2eaab8eca73c40e847ede67ff5e7757ec512 Bug: chromium:1331333 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/262811 Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org> Cr-Original-Commit-Position: refs/heads/main@{#36939} Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264981 Commit-Queue: Evan Shrubsole <eshr@webrtc.org> Cr-Commit-Position: refs/branch-heads/5060@{#2} Cr-Branched-From: 1389c76-refs/heads/main@{#36868}
The current code assumed that chunks that were scheduled for fast retransmission would never be abandoned, as chunks marked for fast retransmission would be immediately sent after the SACK has been processed, giving no time for them to be abandoned. But fuzzers keep on fuzzing, and can craft a sequence of chunks that result in a SACK that both marks the chunks for fast retransmission and later (while processing the same SACK) abandons them. (cherry picked from commit 7726b7d) Bug: chromium:1331087 Change-Id: Id218607e18a6f3a9d6d51044dccb920e1e77372a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/264960 Commit-Queue: Florent Castelli <orphis@webrtc.org> Auto-Submit: Victor Boivie <boivie@webrtc.org> Reviewed-by: Florent Castelli <orphis@webrtc.org> Cr-Original-Commit-Position: refs/heads/main@{#37108} Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265163 Cr-Commit-Position: refs/branch-heads/5060@{#3} Cr-Branched-From: 1389c76-refs/heads/main@{#36868}
(cherry picked from commit f4a6928) Bug: chromium:1330019 Change-Id: I1a22967dff3231c1522fb94de38b309f441d468e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265442 Reviewed-by: Frank Barchard <fbarchard@google.com> Reviewed-by: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Joe Downing <joedow@google.com> Cr-Original-Commit-Position: refs/heads/main@{#37158} Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/265482 Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/branch-heads/5060@{#4} Cr-Branched-From: 1389c76-refs/heads/main@{#36868}
This is an error that puts the PC into an inconsistent state, so causing a crash is the right thing to do. (cherry picked from commit 3fe8b0d) TBR=hta@webrtc.org Bug: chromium:1341043 Change-Id: Ie1eb89400ad87f0c83634b7073236b07e92ec7ab Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267281 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Henrik Boström <hbos@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Cr-Original-Commit-Position: refs/heads/main@{#37391} No-Presubmit: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/267426 Reviewed-by: Guido Urdaneta <guidou@webrtc.org> Commit-Queue: Taylor Brandstetter <deadbeef@webrtc.org> Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Cr-Commit-Position: refs/branch-heads/5060@{#5} Cr-Branched-From: 1389c76-refs/heads/main@{#36868}
…/update-to-m103 # Conflicts: # media/sctp/sctp_transport_factory.cc # media/sctp/sctp_transport_factory.h # pc/data_channel_integrationtest.cc # pc/peer_connection_integrationtest.cc # sdk/objc/api/peerconnection/RTCPeerConnectionFactory.mm # sdk/objc/native/src/audio/audio_device_ios.mm # video/BUILD.gn # video/frame_buffer_proxy.cc # video/frame_buffer_proxy_unittest.cc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
24 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.