Release 1.7.0 #24
Merged
Release 1.7.0 #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modernizing the code a bit. BUG=None Change-Id: I380e9c2c4b20e3d6fc75d5963b0ed129e722099f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/290997 Reviewed-by: Henrik Boström <hbos@webrtc.org> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Cr-Commit-Position: refs/heads/main@{#39138}
Bug: webrtc:7135, webrtc:14795 Change-Id: I0242a3600d4a156eae2315966e5e59e03be8aeab Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/290998 Commit-Queue: Per Kjellander <perkj@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39139}
Bug: b/263477303 Change-Id: Ifabfd1c015788e944d1b78ba2a0454c29426c5e3 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/290993 Commit-Queue: Christoffer Jansson <jansson@google.com> Reviewed-by: Jeremy Leconte <jleconte@google.com> Cr-Commit-Position: refs/heads/main@{#39140}
Change log: https://chromium.googlesource.com/chromium/src/+log/5c3b57c4c8..e551fb7716 Full diff: https://chromium.googlesource.com/chromium/src/+/5c3b57c4c8..e551fb7716 Changed dependencies * src/base: https://chromium.googlesource.com/chromium/src/base/+log/5e68eb8f03..8ddd0f919d * src/build: https://chromium.googlesource.com/chromium/src/build/+log/e831815137..68a090ea4c * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/ae4ca26382..73218076b1 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/2bc38e6394..8f22bbb7f7 * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/6aa94f676f..451b128dd5 * src/third_party/freetype/src: https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/f80be4e959..d680908af2 * src/third_party/perfetto: https://android.googlesource.com/platform/external/perfetto.git/+log/5d0bac17a2..92ef676d45 * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/38d6645ded..79a16671a7 DEPS diff: https://chromium.googlesource.com/chromium/src/+/5c3b57c4c8..e551fb7716/DEPS No update to Clang. BUG=None Change-Id: Ie892bc12fc0269187353607d9447849c6bd061e4 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/291074 Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#39141}
Bug: chromium:1330308, b/234414450 Change-Id: Iad9d38048b62d2fb99e5c76b072dd929c5e24954 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/291101 Reviewed-by: Erik Språng <sprang@webrtc.org> Commit-Queue: Philip Eliasson <philipel@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39142}
This is used by CRD and export is required for component builds to work properly. Bug: chromium:1291247 Change-Id: I281e490b7d00cbd074b96eac905976af38400f8b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/291200 Reviewed-by: Alexander Cooper <alcooper@chromium.org> Auto-Submit: Salman Malik <salmanmalik@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Salman Malik <salmanmalik@chromium.org> Cr-Commit-Position: refs/heads/main@{#39143}
Bug: None Change-Id: I1bd3f9b5e930df7375313014cdffa19ff1692d15 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/291164 Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com> Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#39144}
This is a reland of commit b802369 Original change's description: > Ensure RTCRtpSenders are always created with one encoding > > It is possible to have AddTransceiver calls with an empty array > of encodings or AddTrack calls. In both cases, before negotiation, > the sender's encodings array would be empty and it was not possible > to update any value. > > Now, a default entry should be created in those cases, allowing to > update the configuration before negotiation. > > Bug: webrtc:10567 > Change-Id: I1271e2965e1a97c1e472451e0ab8867fc24f6c2b > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/290994 > Auto-Submit: Florent Castelli <orphis@webrtc.org> > Reviewed-by: Henrik Boström <hbos@webrtc.org> > Commit-Queue: Florent Castelli <orphis@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#39126} Bug: webrtc:10567 Change-Id: I2d52fa5b1d7cfdc9dce279fcf9faf1e0129c9008 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/291140 Reviewed-by: Henrik Boström <hbos@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39145}
…cketReceiver::DeliverRtcp" This reverts commit 3b96f2c. Reason for revert: Seems to cause test failures and perf regressions in tests: webrtc:14833, and CallPerfTest.Min_Bitrate_VideoAndAudio Original change's description: > Change CallTests to use new PacketReceiver::DeliverRtp and PacketReceiver::DeliverRtcp > > PacketReceiver::DeliverRtp requires delivered packets to have extensions already mapped. > Therefore DirectTransport is provided with the extension mapping. > > CallTests and tests derived from CallTest create transports in different ways, this cl change CallTest to create tests in only one way to simplify how extensions are provided to the transport but at the same time still allows different network behaviour. > > > Change-Id: Ie8b3ad947c170be61e62c02dadf4adedbb3841f1 > Bug: webrtc:7135, webrtc:14795 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/290980 > Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org> > Commit-Queue: Per Kjellander <perkj@webrtc.org> > Reviewed-by: Erik Språng <sprang@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#39137} Bug: webrtc:7135, webrtc:14795, webrtc:14833 Change-Id: Ib6180a47cf7611ed2bc648acc3b9e5cfeec4d9cf No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/291220 Owners-Override: Björn Terelius <terelius@webrtc.org> Auto-Submit: Per Kjellander <perkj@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Commit-Queue: Björn Terelius <terelius@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#39146}
…ding"" This reverts commit fc5d627. Reason for revert: Breaks upstream WPT tests Original change's description: > Reland "Ensure RTCRtpSenders are always created with one encoding" > > This is a reland of commit b802369 > > Original change's description: > > Ensure RTCRtpSenders are always created with one encoding > > > > It is possible to have AddTransceiver calls with an empty array > > of encodings or AddTrack calls. In both cases, before negotiation, > > the sender's encodings array would be empty and it was not possible > > to update any value. > > > > Now, a default entry should be created in those cases, allowing to > > update the configuration before negotiation. > > > > Bug: webrtc:10567 > > Change-Id: I1271e2965e1a97c1e472451e0ab8867fc24f6c2b > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/290994 > > Auto-Submit: Florent Castelli <orphis@webrtc.org> > > Reviewed-by: Henrik Boström <hbos@webrtc.org> > > Commit-Queue: Florent Castelli <orphis@webrtc.org> > > Cr-Commit-Position: refs/heads/main@{#39126} > > Bug: webrtc:10567 > Change-Id: I2d52fa5b1d7cfdc9dce279fcf9faf1e0129c9008 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/291140 > Reviewed-by: Henrik Boström <hbos@webrtc.org> > Reviewed-by: Harald Alvestrand <hta@webrtc.org> > Commit-Queue: Florent Castelli <orphis@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#39145} Bug: webrtc:10567 Change-Id: If9b5adb5debb7c87a15662a8d0f232405a0e8136 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/291221 Auto-Submit: Evan Shrubsole <eshr@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39147}
Bug: webrtc:14833 Change-Id: I584524cca81e17ac91d581daab6030705ad68dac Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/291104 Reviewed-by: Erik Språng <sprang@webrtc.org> Commit-Queue: Erik Språng <sprang@webrtc.org> Auto-Submit: Per Kjellander <perkj@webrtc.org> Commit-Queue: Per Kjellander <perkj@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39148}
Bug: webrtc:14653 Change-Id: I0c59604b218d0839a126c02914626b8ed2bee76c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/291040 Commit-Queue: Fredrik Hernqvist <fhernqvist@google.com> Reviewed-by: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39149}
This is a reland of commit b802369 Original change's description: > Ensure RTCRtpSenders are always created with one encoding > > It is possible to have AddTransceiver calls with an empty array > of encodings or AddTrack calls. In both cases, before negotiation, > the sender's encodings array would be empty and it was not possible > to update any value. > > Now, a default entry should be created in those cases, allowing to > update the configuration before negotiation. > > Bug: webrtc:10567 > Change-Id: I1271e2965e1a97c1e472451e0ab8867fc24f6c2b > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/290994 > Auto-Submit: Florent Castelli <orphis@webrtc.org> > Reviewed-by: Henrik Boström <hbos@webrtc.org> > Commit-Queue: Florent Castelli <orphis@webrtc.org> > Cr-Commit-Position: refs/heads/main@{#39126} Bug: webrtc:10567 Change-Id: I558a95f7b587302b5e95f6ec26d1eb1fedf3dbed Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/291240 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Florent Castelli <orphis@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39150}
Bug: webrtc:13757 Change-Id: I5244ed1148f628df9482f934fdfb509e511a9856 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/291103 Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Emil Lundmark <lndmrk@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39151}
This should help to debug problems with DNS resolution of turn server name. E.g. DNS server returns fake IP address to block turn server. Similar change to stun_port.cc were done in https://webrtc-review.googlesource.com/c/src/+/215926 Bug: None Change-Id: If1cc410f4cd0f89620d3678aabf05a0f1b22a393 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/290992 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Yury Yarashevich <yura.yaroshevich@gmail.com> Cr-Commit-Position: refs/heads/main@{#39152}
Change log: https://chromium.googlesource.com/chromium/src/+log/e551fb7716..09356cf622 Full diff: https://chromium.googlesource.com/chromium/src/+/e551fb7716..09356cf622 Changed dependencies * src/base: https://chromium.googlesource.com/chromium/src/base/+log/8ddd0f919d..b317709a6d * src/build: https://chromium.googlesource.com/chromium/src/build/+log/68a090ea4c..f87127474b * src/buildtools/reclient: re_client_version:0.87.0.b6908b3-gomaip..re_client_version:0.93.0.9ed3cef-gomaip * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/73218076b1..6f952f13c9 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/8f22bbb7f7..72f688213d * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/451b128dd5..b4079b157f * src/third_party/android_deps/libs/org_jetbrains_kotlin_kotlin_stdlib: version:2@1.7.10.cr1..version:2@1.8.0.cr1 * src/third_party/android_deps/libs/org_jetbrains_kotlin_kotlin_stdlib_common: version:2@1.7.10.cr1..version:2@1.8.0.cr1 * src/third_party/android_deps/libs/org_jetbrains_kotlin_kotlin_stdlib_jdk7: version:2@1.6.20.cr1..version:2@1.8.0.cr1 * src/third_party/android_deps/libs/org_jetbrains_kotlin_kotlin_stdlib_jdk8: version:2@1.6.20.cr1..version:2@1.8.0.cr1 * src/third_party/androidx: btXkjr59BovHt7mjeB3OxCJisQRYv3qijJneQHYON6cC..z1Ltgk5lzJuoEqOSTMM3F1QuAXbGFIEN6SQ0jX4qHd0C * src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/7a311fe439..1a41c2d59d * src/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/86cfa62b07..bf7eb5292c * src/third_party/freetype/src: https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/d680908af2..82ce172669 * src/third_party/libaom/source/libaom: https://aomedia.googlesource.com/aom.git/+log/c047ec16b8..0b76cc07c5 * src/third_party/perfetto: https://android.googlesource.com/platform/external/perfetto.git/+log/92ef676d45..0d57f4770c * src/third_party/r8: jVbxJPYj2eIXMIU3dCVMjSFcpEcwBGbSzKKfgoTM9tIC..P1d7YJypbKC2Tv6UCo5QRdo1UwIyECszSGO583AzYigC * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/79a16671a7..5622a601bb DEPS diff: https://chromium.googlesource.com/chromium/src/+/e551fb7716..09356cf622/DEPS Clang version changed llvmorg-16-init-14635-ga650f2ec:llvmorg-16-init-17653-g39da55e8 Details: https://chromium.googlesource.com/chromium/src/+/e551fb7716..09356cf622/tools/clang/scripts/update.py BUG=None Change-Id: I3dd27b7d553af0bbcffff6c7912440f80ef23af9 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/291171 Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#39153}
Implement GetProcessResidentSizeBytes for Fuchsia. Bug: webrtc:14825 Change-Id: I64582ce0da72d3bb0fa61ff64799a1a165e1192f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/290922 Commit-Queue: Sarah Pham <smpham@google.com> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39154}
Change log: https://chromium.googlesource.com/chromium/src/+log/09356cf622..c97ba0b8b1 Full diff: https://chromium.googlesource.com/chromium/src/+/09356cf622..c97ba0b8b1 Changed dependencies * src/base: https://chromium.googlesource.com/chromium/src/base/+log/b317709a6d..c205d5d5e2 * src/build: https://chromium.googlesource.com/chromium/src/build/+log/f87127474b..dac013f262 * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/6f952f13c9..48df4e6c61 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/72f688213d..410234368a * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/b4079b157f..05a37f2d47 * src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/1a41c2d59d..4d42668497 * src/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/bf7eb5292c..c8f23e26be * src/third_party/perfetto: https://android.googlesource.com/platform/external/perfetto.git/+log/0d57f4770c..53971a4039 * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/5622a601bb..c2192e9649 DEPS diff: https://chromium.googlesource.com/chromium/src/+/09356cf622..c97ba0b8b1/DEPS No update to Clang. BUG=None Change-Id: I883e45c2ea57c169f93df3fb5fdf6a1c5788b03d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/291184 Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#39155}
Bug: None Change-Id: I7a24b900ad511df687693339516cc6d757f9145d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/291173 Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com> Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#39156}
…cketReceiver::DeliverRtcp" This reverts commit 3e61f88. Reason for revert: Issue fixed in https://webrtc-review.googlesource.com/c/src/+/291104 Original change's description: > Revert "Change CallTests to use new PacketReceiver::DeliverRtp and PacketReceiver::DeliverRtcp" > > This reverts commit 3b96f2c. > > Reason for revert: Seems to cause test failures and perf regressions in tests: webrtc:14833, and CallPerfTest.Min_Bitrate_VideoAndAudio > > > Original change's description: > > Change CallTests to use new PacketReceiver::DeliverRtp and PacketReceiver::DeliverRtcp > > > > PacketReceiver::DeliverRtp requires delivered packets to have extensions already mapped. > > Therefore DirectTransport is provided with the extension mapping. > > > > CallTests and tests derived from CallTest create transports in different ways, this cl change CallTest to create tests in only one way to simplify how extensions are provided to the transport but at the same time still allows different network behaviour. > > > > > > Change-Id: Ie8b3ad947c170be61e62c02dadf4adedbb3841f1 > > Bug: webrtc:7135, webrtc:14795 > > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/290980 > > Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org> > > Commit-Queue: Per Kjellander <perkj@webrtc.org> > > Reviewed-by: Erik Språng <sprang@webrtc.org> > > Cr-Commit-Position: refs/heads/main@{#39137} > > Bug: webrtc:7135, webrtc:14795, webrtc:14833 > Change-Id: Ib6180a47cf7611ed2bc648acc3b9e5cfeec4d9cf > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/291220 > Owners-Override: Björn Terelius <terelius@webrtc.org> > Auto-Submit: Per Kjellander <perkj@webrtc.org> > Reviewed-by: Björn Terelius <terelius@webrtc.org> > Commit-Queue: Björn Terelius <terelius@webrtc.org> > Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#39146} Bug: webrtc:7135, webrtc:14795, webrtc:14833 Change-Id: I3fb0210d7a33c600ead5719ce2acb8cc68ec20bd Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/291222 Commit-Queue: Per Kjellander <perkj@webrtc.org> Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org> Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Per Kjellander <perkj@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39157}
Change log: https://chromium.googlesource.com/chromium/src/+log/c97ba0b8b1..2fb5e2fb16 Full diff: https://chromium.googlesource.com/chromium/src/+/c97ba0b8b1..2fb5e2fb16 Changed dependencies * src/base: https://chromium.googlesource.com/chromium/src/base/+log/c205d5d5e2..c93d6064b4 * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/48df4e6c61..cab174be8f * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/410234368a..73d2243e70 * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/05a37f2d47..f4a84db7a3 * src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/4d42668497..e4385f1ba0 * src/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c8f23e26be..aec39c38f8 * src/third_party/libaom/source/libaom: https://aomedia.googlesource.com/aom.git/+log/0b76cc07c5..5115747345 * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/c2192e9649..301298c451 DEPS diff: https://chromium.googlesource.com/chromium/src/+/c97ba0b8b1..2fb5e2fb16/DEPS No update to Clang. BUG=None Change-Id: I1f9a11f91fae8c50956e95b2a95e659f4e04ffbc Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/291175 Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#39158}
Certificates being missing is a sign of a bug (e.g. webrtc:14844, to be fixed separately) which is why we have a DCHECK. But this DCHECK does not protect against accessing the invalid iterator if it is a release build. This CL makes that safe. Bug: chromium:1408392 Change-Id: I97a82786028e41c58ef8ef15002c3f959bbec7f1 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/291109 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39159}
Creating a data channel or negotiating it can make the SCTP transport name go from nothing (empty string) to something. Inside the RTCStatsCollector this is relevant because which transports we have affect which certificates we should cache, so this is an instance of having to call ClearStatsCache(). The bug is that we don't. This CL fixes the bug. I tried to create unittests to cover this, but I was unable to reproduce the race in a testing environment (if I did it would have hit an RTC_DCHECK). Not ideal... but I hope we can land it anyway since the fix is trivial and clearing the cache in response to API calls is worst case harmless. Bug: webrtc:14844 Change-Id: Ia7174cde040839e5555237db6de285297120b123 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/291112 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39160}
Based on offline testing; needed to allow input volume adaptations more frequently. Note that if the estimated speech level falls in the target range, the recommended input volume won't change and hence the new lower threshold won't necessarily increase the number of adjustments. Bug: webrtc:7494 Change-Id: Iabb501c188da238ea7b7137175bcfe09239c90a2 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/291110 Reviewed-by: Hanna Silen <silen@webrtc.org> Commit-Queue: Alessio Bazzica <alessiob@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39161}
Change log: https://chromium.googlesource.com/chromium/src/+log/2fb5e2fb16..92aea4500e Full diff: https://chromium.googlesource.com/chromium/src/+/2fb5e2fb16..92aea4500e Changed dependencies * src/base: https://chromium.googlesource.com/chromium/src/base/+log/c93d6064b4..50eaeff67e * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/cab174be8f..2ad8e2ea06 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/73d2243e70..a5512ff5ec * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/f4a84db7a3..35350960af * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/301298c451..50ee6c1a8c DEPS diff: https://chromium.googlesource.com/chromium/src/+/2fb5e2fb16..92aea4500e/DEPS No update to Clang. BUG=None Change-Id: Iafafe397740e37920e5065675df22d3c6340e868 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/291260 Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#39162}
so it can be used in downstream Chrome tests BUG=None Change-Id: I4b3e1f172e8eb2ba01ab5c257f3626223781da31 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/291116 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Florent Castelli <orphis@webrtc.org> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Cr-Commit-Position: refs/heads/main@{#39163}
Bug: none Change-Id: I3f38f26eb84379cf64a39c9595ceb6bf235558a1 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/291111 Commit-Queue: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39164}
These are needed by crrev.com/c/4165083. Bug: chromium:1369096, webrtc:14131 Change-Id: Id0a46254b46cf866f2f3b7b07b97dc55066c047f Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/291117 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39165}
Change log: https://chromium.googlesource.com/chromium/src/+log/92aea4500e..e0c02c1406 Full diff: https://chromium.googlesource.com/chromium/src/+/92aea4500e..e0c02c1406 Changed dependencies * src/base: https://chromium.googlesource.com/chromium/src/base/+log/50eaeff67e..718df78ad3 * src/build: https://chromium.googlesource.com/chromium/src/build/+log/dac013f262..0c3dd023b8 * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/2ad8e2ea06..accdd4e600 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/a5512ff5ec..3892949280 * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/35350960af..3d573eed4a * src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/3251ca1f63..45b8d7bbd7 * src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/e4385f1ba0..5eeb59b9e9 * src/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/aec39c38f8..7c6ebe7fd1 * src/third_party/perfetto: https://android.googlesource.com/platform/external/perfetto.git/+log/53971a4039..61f6f28a07 * src/third_party/r8: P1d7YJypbKC2Tv6UCo5QRdo1UwIyECszSGO583AzYigC..-zULvtoUlL3ZlX-wYBRJuptakgqclqk9dpsQizt8gysC * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/50ee6c1a8c..b6ce0136e2 DEPS diff: https://chromium.googlesource.com/chromium/src/+/92aea4500e..e0c02c1406/DEPS No update to Clang. BUG=None Change-Id: I674fa11be6093820fe34c6e80734a7f3c691ce8e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/291264 Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#39166}
Change log: https://chromium.googlesource.com/chromium/src/+log/e0c02c1406..0c3ca8fbc7 Full diff: https://chromium.googlesource.com/chromium/src/+/e0c02c1406..0c3ca8fbc7 Changed dependencies * src/base: https://chromium.googlesource.com/chromium/src/base/+log/718df78ad3..c35c2bd252 * src/build: https://chromium.googlesource.com/chromium/src/build/+log/0c3dd023b8..372a5a7aba * src/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/dc82f3042d..d520d582aa * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/3892949280..3e400c1ded * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/3d573eed4a..a6e8f4bdbb * src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/5eeb59b9e9..c4e9d16032 * src/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7c6ebe7fd1..e852391441 * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/b6ce0136e2..4f15a22bf3 DEPS diff: https://chromium.googlesource.com/chromium/src/+/e0c02c1406..0c3ca8fbc7/DEPS No update to Clang. BUG=None Change-Id: I444f10dbcba4f63b01aba1b55058fd98be52b072 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/291267 Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#39167}
This CL gives the ability to explicitly set the network labels in the network quality metrics reporter, so that reported metrics can be aligned with peer names in case "alice" and "bob" are not used as peer names. Bug: webrtc:14897 Change-Id: Ib66d4683af71ff4302696aff4dcb9932b47e4efd Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/293161 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Artem Titov <titovartem@webrtc.org> Reviewed-by: Andrey Logvin <landrey@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Commit-Queue: Artem Titov <titovartem@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39360}
…creencast_portal.(cc|h) Bug: webrtc:14917 Change-Id: I40e8f011b7263675aab99c452cda8f89ad137cc5 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/294283 Auto-Submit: Björn Terelius <terelius@webrtc.org> Reviewed-by: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/main@{#39361}
Change log: https://chromium.googlesource.com/chromium/src/+log/bc324e05cd..d76cada124 Full diff: https://chromium.googlesource.com/chromium/src/+/bc324e05cd..d76cada124 Changed dependencies * fuchsia_vesion: version:11.20230221.0.1..version:11.20230221.2.1 * src/base: https://chromium.googlesource.com/chromium/src/base/+log/f354a1f6fd..0fc91d5d90 * src/build: https://chromium.googlesource.com/chromium/src/build/+log/07ec6f3a67..07283ef796 * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/3702bec69f..143d6295ff * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/55a2da42a2..b93e19cb40 * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/35d4bb70e7..82835c7ebd * src/third_party/android_build_tools/aapt2: cbNG7g8Sinh-lsT8hWsU-RyXqLT_uh4jIb1fjCdhrzIC..36NqCian2RIwuM6SFfizdUgKoXyZhy3q6pFfsws0szYC * src/third_party/android_build_tools/manifest_merger: EnlN2b-khJhe8B9hSfh7UxvglJXEwWDKaMm4ixhLYTMC..EbRaK62t9grqlZqL-JTd_zwM4t1u9fm1x4c2rLE0cqQC * src/third_party/perfetto: https://android.googlesource.com/platform/external/perfetto.git/+log/e85c60ec55..55985e77ff * src/third_party/r8/d8: qGtBu6TtxyR5XNy4cmsslb7c946YtkZF5_QCjVP-wc8C..PwglNZFRNPkBBXdnY9NfrZFk2ULWDTRxhV9rl2kvkpUC * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/e23ae148de..6e72739081 DEPS diff: https://chromium.googlesource.com/chromium/src/+/bc324e05cd..d76cada124/DEPS No update to Clang. BUG=None Change-Id: I61144a5720b9d6c1a5cfc309fbd9a8ff5f8e78fa Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/294460 Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#39362}
verifying these are transferred to the individual m-lines. Also verify that mixed usage both at session level as well as media level is not allowed as described in https://www.rfc-editor.org/rfc/rfc5285#section-6 BUG=None Change-Id: Iade387817c9f31362d0a26c5f13a3012c72b51b0 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/294360 Reviewed-by: Florent Castelli <orphis@webrtc.org> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39363}
Bug: webrtc:14919 Change-Id: Iba00b2782b7e7c3dbd345a94aba541fad8c979ee Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/294289 Commit-Queue: Jesus de Vicente Pena <devicentepena@webrtc.org> Reviewed-by: Gustaf Ullberg <gustaf@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39364}
This test verifies perkj's fixes in https://crbug.com/webrtc/14817. I ran the test 6000 times locally and it didn't fail once. Bug: webrtc:14817 Change-Id: I3f78f3ae2ca09b328cbfa12a89ad228d3de899c2 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/294522 Reviewed-by: Per Kjellander <perkj@webrtc.org> Commit-Queue: Per Kjellander <perkj@webrtc.org> Auto-Submit: Henrik Boström <hbos@webrtc.org> Commit-Queue: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39365}
in favor of the variant with (or returning) a Timestamp object. BUG=webrtc:14813,webrtc:13756 Change-Id: I7b40f48f640a8be40a134b380a7a1b99cc99913b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/294287 Reviewed-by: Henrik Boström <hbos@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Cr-Commit-Position: refs/heads/main@{#39366}
This class is used for both simulcast and SVC use cases. Update variable names and code comments to reflect this fact. Also add TODOs that we'll need to address for VP9 simulcast. Bug: webrtc:14884 Change-Id: I814c8fa0097306b16d552f55ca391ac8f716348a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/294383 Commit-Queue: Henrik Boström <hbos@webrtc.org> Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Reviewed-by: Erik Språng <sprang@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39367}
Bug: webrtc:11031 Change-Id: I44405d0d15e885307b3134b1b88dcb74b96381fb Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/294400 Reviewed-by: Erik Språng <sprang@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39368}
Replace the existing variable capture_time_identifier_ms_ with capture_time_identifier_ in webrtc::VideoFrame and webrtc::VideoFrame::Builder. This variable uses webrtc::Timestamp as its type versus using int64_t which creates confusion about whether it is being recorded in milliseconds/microseconds. Change-Id: I0b83a6235fb1d5732f7afe2c14d7d6121f1e985b Bug: webrtc:14878 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/293520 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Palak Agarwal <agpalak@google.com> Cr-Commit-Position: refs/heads/main@{#39369}
With LTR and SVC etc., H.264 should be able to skip lost frames, and continue to play from the new frames. With DependencyDescriptor, it is allowed to reference the previous frames, even there is a gap in the middle. However, we found there is a special logic for H.264 in packet_buffer.cc, which requires no gap for H.264. We should allow gaps if the packet has GenericDescriptorInfo (either GenericDescriptor or DependencyDescriptor header extension). Bug: webrtc:14887 Change-Id: Id66726bab33229bd883f257136ff2e8523fb44c0 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/294062 Commit-Queue: Philip Eliasson <philipel@webrtc.org> Reviewed-by: Philip Eliasson <philipel@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39370}
This uses the field trial introduced is crbug.com/1406331 and extends the usage to OpenH264. This simplifies experimentation whether this change improves performance without requiring multi-slice encoding. BUG=webrtc:14368 Change-Id: I0031e59059f7113dd5453234869c957d46f311bb Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/294340 Reviewed-by: Erik Språng <sprang@webrtc.org> Reviewed-by: Sergey Silkin <ssilkin@webrtc.org> Reviewed-by: Henrik Boström <hbos@webrtc.org> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Cr-Commit-Position: refs/heads/main@{#39371}
Without the flag enabled: https://screenshot.googleplex.com/BZ6fqsNHQAUxbyU With the flag enabled: https://screenshot.googleplex.com/4GKrfvAdUpsQDx9 Bug: webrtc:12707 Change-Id: Ia1a9761aeaedc57cff6a2d1eca3c61519b9dd26e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/293660 Commit-Queue: Diep Bui <diepbp@webrtc.org> Reviewed-by: Per Kjellander <perkj@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39372}
Bug: webrtc:13931, webrtc:14920 Change-Id: I451869e295e099a1d08c0c80e481decd53149f1b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/294382 Reviewed-by: Henrik Boström <hbos@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39373}
This CL propagates capture_time_identifier introduced in webrtc::VideoFrame and propagates it to EncodedImage. For use cases involving EncodedTransforms, this identifier is further propagated to TransformableVideoSenderFrame. VideoEncoder::Encode function is overriden by each encoder. Each of these overriden functions needs to be changed so that they can handle this new identifier and propagate its value in the created EncodedImage. Change-Id: I5bea4c5a3fe714f1198e497a4bcb5fd059afe516 Bug: webrtc:14878 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/291800 Reviewed-by: Tony Herre <herre@google.com> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Palak Agarwal <agpalak@google.com> Cr-Commit-Position: refs/heads/main@{#39374}
Bug: webrtc:14708 Change-Id: I7926b3cfa6530e02eb13c31fecbc9e2e73f78f71 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/293744 Reviewed-by: Tove Petersson <tovep@google.com> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Commit-Queue: Tony Herre <herre@google.com> Cr-Commit-Position: refs/heads/main@{#39375}
The Xenial instrumented libraries are no longer used and can be removed. Bug: chromium:1260217 Change-Id: If3e7cb97f8e6d1b1b482e43885b215d5b199333e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/294640 Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#39376}
…back Since AddTrack now has an implicit init_encodings value, it will also have a StableState saved when associating a transceiver. That state may not have a saved mid and mline_index, and so on a rollback, it could blindly reset the mid and mline_index of an associated transceiver. This is wrong, the mid and mline_index of associated transceivers should only be updated when the StableState objects actually have one saved. (cherry picked from commit b3d424c) Bug: chromium:1424238 Change-Id: I8e80a04cd072d90200ca7643de892c0ef29b1f1a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/297920 Commit-Queue: Florent Castelli <orphis@webrtc.org> Reviewed-by: Henrik Boström <hbos@webrtc.org> Cr-Original-Commit-Position: refs/heads/main@{#39577} Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/297983 Reviewed-by: Per Kjellander <perkj@webrtc.org> Commit-Queue: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/branch-heads/5615@{#1} Cr-Branched-From: cdfeb4f-refs/heads/main@{#39376}
This reverts commit be03c09. Causes regression in web projects that 1/ add a stopped-by-default extension in SRD 2/ call createAnswer 3/ munge the stopped-by-default extension back in SLD 4/ create a subsequent offer and expect the extension to be present BUG=chromium:1427442,chromium:1051821 Change-Id: I2e48831e92384963a254d873398f54eaee96739a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/299143 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Philipp Hancke <phancke@microsoft.com> Reviewed-by: Henrik Boström <hbos@webrtc.org> Cr-Commit-Position: refs/branch-heads/5615@{#2} Cr-Branched-From: cdfeb4f-refs/heads/main@{#39376}
…to-m112 # Conflicts: # call/rtp_payload_params.cc # call/rtp_video_sender.cc # call/rtp_video_sender_unittest.cc # net/dcsctp/tx/outstanding_data_test.cc # pc/rtp_sender_receiver_unittest.cc # sdk/objc/api/peerconnection/RTCPeerConnectionFactory.h # sdk/objc/api/peerconnection/RTCPeerConnectionFactory.mm # sdk/objc/native/src/audio/audio_device_ios.h # tools_webrtc/ios/build_ios_libs.py
Update WebRTC to m112
…ocessing-for-playback Disable voice processing for playback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
29 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.