M140 -> M139 #36
Open
M140 -> M139 #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bs.py After migrating the script to use Siso, the script doesn't work if the output dir isn't under SRC_DIR. https://webrtc-review.googlesource.com/c/src/+/391480/comments/f8acc07e_f5d582a1 This CL adds a check to show a user friendly error. Bug: b/412968361 Change-Id: Ib7cf46390caa5b1477d2e43f3aec730dfc90e03d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/398000 Commit-Queue: Christoffer Dewerin <jansson@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Auto-Submit: Junji Watanabe <jwata@google.com> Reviewed-by: Christoffer Dewerin <jansson@webrtc.org> Cr-Commit-Position: refs/heads/main@{#45026}
When the delay-based estimate and a 2% bandwidth-increase candidate had the same kbps but different bps, the algorithm selected the latter. This resulted in a lower bandwidth selection than the delay-based estimate, triggering unnecessary padding. With this change, the higher bandwidth candidate will be selected if having the same kbps. Bug: webrtc:12707,webrtc:427648364 Change-Id: I1ed042689317c768b773d7e6f0819690c38f0e56 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/398080 Commit-Queue: Diep Bui <diepbp@webrtc.org> Reviewed-by: Per Kjellander <perkj@webrtc.org> Cr-Commit-Position: refs/heads/main@{#45027}
Change log: https://chromium.googlesource.com/chromium/src/+log/ff8c208486..5b929b805f Full diff: https://chromium.googlesource.com/chromium/src/+/ff8c208486..5b929b805f Changed dependencies * siso_version: git_revision:c23de742b8483ddc09d8b68ef845efc7f5c6192f..git_revision:13b7a626dcadfb49c7f4759a44095cebea6e91bc * src/build: https://chromium.googlesource.com/chromium/src/build/+log/11e4ed2be5..bf9220209e * src/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/ece689efbe..f7862e515c * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/e14a018a8c..e6487e5502 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/f9ba8b7488..10a9fcbaf8 * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/ade90f0d60..5c484b4d43 * src/third_party/android_deps/autorolled/cipd: A3dJOufp8dbBYcfXrWzJNEzSO4qpqACgdZsVLdeWym8C..uAGMRg6ZxK3ETC5Ukkh-z3s1v3gzyeTZ8PJk-H9dQFUC * src/third_party/androidx/cipd: Xp4dLPNEQw9LV2KtUG8BZ2oHdHYFi2qUqR-3Exjwx-gC..4dpv4QrFOz1VCy2wyNGhxG563aJ_bmOogdkOLkt8tQAC * src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/21d0515a86..78b48c1f2a * src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/0c0721de3c..8b6c661e42 * src/third_party/compiler-rt/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/compiler-rt.git/+log/2a4f69a118..4ba5dd1391 * src/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/488ad9dd22..838762e3ae * src/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/f8ed0e687c..a45468c0fc * src/third_party/grpc/src: https://chromium.googlesource.com/external/github.com/grpc/grpc.git/+log/58d3117e7b..a15b40daef * src/third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/2c359c239b..b5d83e70a1 * src/third_party/libc++abi/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/e44c3c4560..02570151a8 * src/third_party/perfetto: https://chromium.googlesource.com/external/github.com/google/perfetto.git/+log/47b5a5c57b..0e1580cdec * src/third_party/r8/d8/cipd: F0pTWc6uG70kZPngypnQxCgD3CgY5D8O-pDqj_qeoQMC..9vZCRnASPSjh3_T-2AsumCO_8C5PuBJ5-e84K9b7-80C * src/third_party/rust-toolchain: Linux_x64/rust-toolchain-22be76b7e259f27bf3e55eb931f354cd8b69d55f-1-llvmorg-21-init-16348-gbd809ffb.tar.xz,Mac/rust-toolchain-22be76b7e259f27bf3e55eb931f354cd8b69d55f-1-llvmorg-21-init-16348-gbd809ffb.tar.xz,Mac_arm64/rust-toolchain-22be76b7e259f27bf3e55eb931f354cd8b69d55f-1-llvmorg-21-init-16348-gbd809ffb.tar.xz,Win/rust-toolchain-22be76b7e259f27bf3e55eb931f354cd8b69d55f-1-llvmorg-21-init-16348-gbd809ffb.tar.xz..Linux_x64/rust-toolchain-22be76b7e259f27bf3e55eb931f354cd8b69d55f-3-llvmorg-21-init-16348-gbd809ffb.tar.xz,Mac/rust-toolchain-22be76b7e259f27bf3e55eb931f354cd8b69d55f-3-llvmorg-21-init-16348-gbd809ffb.tar.xz,Mac_arm64/rust-toolchain-22be76b7e259f27bf3e55eb931f354cd8b69d55f-3-llvmorg-21-init-16348-gbd809ffb.tar.xz,Win/rust-toolchain-22be76b7e259f27bf3e55eb931f354cd8b69d55f-3-llvmorg-21-init-16348-gbd809ffb.tar.xz * src/third_party/siso/cipd: git_revision:c23de742b8483ddc09d8b68ef845efc7f5c6192f..git_revision:13b7a626dcadfb49c7f4759a44095cebea6e91bc * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/0a24261d17..666b5eca2f DEPS diff: https://chromium.googlesource.com/chromium/src/+/ff8c208486..5b929b805f/DEPS BUG=None Change-Id: I89a5efaea5c3b50dd9bca250387ac1dbc728f2e6 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/398045 Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#45028}
Change log: https://chromium.googlesource.com/chromium/src/+log/5b929b805f..3e575cefc5 Full diff: https://chromium.googlesource.com/chromium/src/+/5b929b805f..3e575cefc5 Changed dependencies * src/build: https://chromium.googlesource.com/chromium/src/build/+log/bf9220209e..9cfbcbcdd9 * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/e6487e5502..a94141f495 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/10a9fcbaf8..78457247d1 * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/5c484b4d43..f4ab6fb8b3 * src/third_party/androidx/cipd: 4dpv4QrFOz1VCy2wyNGhxG563aJ_bmOogdkOLkt8tQAC..SUAslRJb4ktclL8I0SFgXXf3Yyp5y0IOieZHkouN16MC * src/third_party/grpc/src: https://chromium.googlesource.com/external/github.com/grpc/grpc.git/+log/a15b40daef..d86407d578 * src/third_party/perfetto: https://chromium.googlesource.com/external/github.com/google/perfetto.git/+log/0e1580cdec..56db392a01 * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/666b5eca2f..e30a93bac9 DEPS diff: https://chromium.googlesource.com/chromium/src/+/5b929b805f..3e575cefc5/DEPS BUG=None Change-Id: Icc9184955ac6bf029fddb86affc4ba44db0c760d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/398180 Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#45029}
Change log: https://chromium.googlesource.com/chromium/src/+log/3e575cefc5..b546d41b18 Full diff: https://chromium.googlesource.com/chromium/src/+/3e575cefc5..b546d41b18 Changed dependencies * src/build: https://chromium.googlesource.com/chromium/src/build/+log/9cfbcbcdd9..ce1ecbec95 * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/a94141f495..f72683fede * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/78457247d1..cdde814bc1 * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/f4ab6fb8b3..f9fc46f8bb * src/third_party/androidx/cipd: SUAslRJb4ktclL8I0SFgXXf3Yyp5y0IOieZHkouN16MC..R4_xK2W3ql3CpliF97siZrtL1thdeO9goKOOCRjZ51oC * src/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/838762e3ae..4f1723dd1f * src/third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/79a5aa1b7f..d9dd3097ff * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/e30a93bac9..33a693641b * src/tools/luci-go: git_revision:6c2c13d25bc8014a0da038302089bc3e9b236931..git_revision:e18061c271a8bd452f0205e61ca71f872a48ba9c * src/tools/luci-go: git_revision:6c2c13d25bc8014a0da038302089bc3e9b236931..git_revision:e18061c271a8bd452f0205e61ca71f872a48ba9c * src/tools/luci-go: git_revision:6c2c13d25bc8014a0da038302089bc3e9b236931..git_revision:e18061c271a8bd452f0205e61ca71f872a48ba9c DEPS diff: https://chromium.googlesource.com/chromium/src/+/3e575cefc5..b546d41b18/DEPS BUG=None Change-Id: Ib8a37c020b32aa9611ad9a1912676af1dcae7863 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/398161 Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#45030}
Change log: https://chromium.googlesource.com/chromium/src/+log/b546d41b18..3ad18fd171 Full diff: https://chromium.googlesource.com/chromium/src/+/b546d41b18..3ad18fd171 Changed dependencies * fuchsia_version: version:28.20250609.4.1..version:28.20250626.4.1 * src/build: https://chromium.googlesource.com/chromium/src/build/+log/ce1ecbec95..88a58be920 * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/f72683fede..b8b33355a1 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/cdde814bc1..c70704b13e * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/f9fc46f8bb..b73e151cca * src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/8b6c661e42..57fbead964 * src/third_party/grpc/src: https://chromium.googlesource.com/external/github.com/grpc/grpc.git/+log/d86407d578..5d149e33dc * src/third_party/perfetto: https://chromium.googlesource.com/external/github.com/google/perfetto.git/+log/56db392a01..6766ffc985 * src/third_party/re2/src: https://chromium.googlesource.com/external/github.com/google/re2.git/+log/c84a140c93..652b816bfd * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/33a693641b..81a6368225 DEPS diff: https://chromium.googlesource.com/chromium/src/+/b546d41b18..3ad18fd171/DEPS BUG=None Change-Id: I96c374e8a3b6204ee2c34aca871ca25d4a349ca0 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/398221 Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#45031}
Change log: https://chromium.googlesource.com/chromium/src/+log/3ad18fd171..caf05a9b75 Full diff: https://chromium.googlesource.com/chromium/src/+/3ad18fd171..caf05a9b75 Changed dependencies * src/build: https://chromium.googlesource.com/chromium/src/build/+log/88a58be920..1c14ac6508 * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/b8b33355a1..fa9d6e9136 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/c70704b13e..15136888f9 * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/b73e151cca..65f7cc8394 * src/third_party/android_build_tools/lint/cipd: RevkTwhOQRk-oOzI4BBk3FYEeVAlBijeTqjNPrGsi_8C..eWRdzGzH7yQ87tWs3ziVgS5K-hEL5sDdOZgIR2pSduoC * src/third_party/android_build_tools/manifest_merger/cipd: v0s5-TwZ9OxfzbqU5ULhQ7vufSuKIIld6Z7TK8artzoC..QmC9cZkulirpeFoG7WaWIGRovPGsS8sMpycIswB1CwkC * src/third_party/androidx/cipd: R4_xK2W3ql3CpliF97siZrtL1thdeO9goKOOCRjZ51oC..wX5EnG9kBELAKhe-Am3XeFZgh6l3H2oYrndg3RYtxUcC * src/third_party/kotlin_stdlib/cipd: Ly_nOcmB3VyAmA3kTKonDTj_hmJ8y1ij5aTcLYpERbYC..WLQWx0tEKXoFb4sUHvEBIdL5AUzDW0bUkyFYMclPZlQC * src/third_party/perfetto: https://chromium.googlesource.com/external/github.com/google/perfetto.git/+log/6766ffc985..d6a79b5507 * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/81a6368225..7b932c35eb DEPS diff: https://chromium.googlesource.com/chromium/src/+/3ad18fd171..caf05a9b75/DEPS BUG=None Change-Id: I4a6b826fa86fc609dbbf0a84a3189d136793d626 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/398240 Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#45032}
Bug: None Change-Id: Ib58a12a0d184aa84573893d115fbb06407022d94 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/398241 Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com> Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#45033}
yay, it turned out that this was a test case problem rather than a code problem. "callee_active" with dtls_in_stun is not supported...(which was somehow missed in the check...) BUG=webrtc:367395350 Change-Id: I1f1f5ebf809008e1659bfccd1d46f67e0aa09d68 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/398200 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Auto-Submit: Jonas Oreland <jonaso@webrtc.org> Cr-Commit-Position: refs/heads/main@{#45034}
Change log: https://chromium.googlesource.com/chromium/src/+log/caf05a9b75..238a28281c Full diff: https://chromium.googlesource.com/chromium/src/+/caf05a9b75..238a28281c Changed dependencies * src/build: https://chromium.googlesource.com/chromium/src/build/+log/1c14ac6508..71876cfb44 * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/fa9d6e9136..93f85b6f37 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/15136888f9..2cce26323b * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/65f7cc8394..7130eb3517 * src/third_party/androidx/cipd: wX5EnG9kBELAKhe-Am3XeFZgh6l3H2oYrndg3RYtxUcC..-MJyeTXT7Ung7fhrF9zofx6FcjcoRDlb5DNg3qveRa4C * src/third_party/compiler-rt/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/compiler-rt.git/+log/4ba5dd1391..e070357d93 * src/third_party/grpc/src: https://chromium.googlesource.com/external/github.com/grpc/grpc.git/+log/5d149e33dc..cce0ed4afb * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/7b932c35eb..4d5f848ec7 DEPS diff: https://chromium.googlesource.com/chromium/src/+/caf05a9b75..238a28281c/DEPS BUG=None Change-Id: I14f1a7fa70c323959216fce1af106090efe8c9e4 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/398260 Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#45035}
This CL changes the `GetSampleValuesForFrame()` to accept a `VideoFrame` instance instead of a `scoped_refptr<I420BufferInterface>` and also adds native support for NV12 buffers without need for conversion to I420. Bug: webrtc:358039777 Change-Id: Ie488c21cabbda171d3adc2f7b329be9d4e4a1008 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/398100 Reviewed-by: Fanny Linderborg <linderborg@webrtc.org> Commit-Queue: Fanny Linderborg <linderborg@webrtc.org> Commit-Queue: Erik Språng <sprang@webrtc.org> Cr-Commit-Position: refs/heads/main@{#45036}
Bug: webrtc:428147754 Change-Id: Idf6d7534add0b1b096a9997d0c1a3cec00e31768 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/398280 Commit-Queue: Diep Bui <diepbp@webrtc.org> Reviewed-by: Jakob Ivarsson <jakobi@webrtc.org> Cr-Commit-Position: refs/heads/main@{#45037}
Change log: https://chromium.googlesource.com/chromium/src/+log/238a28281c..9981aa6b34 Full diff: https://chromium.googlesource.com/chromium/src/+/238a28281c..9981aa6b34 Changed dependencies * src/build: https://chromium.googlesource.com/chromium/src/build/+log/71876cfb44..56959c64fe * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/93f85b6f37..8fd088dba1 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/2cce26323b..85552b7977 * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/7130eb3517..e7046a4d81 * src/third_party/androidx/cipd: -MJyeTXT7Ung7fhrF9zofx6FcjcoRDlb5DNg3qveRa4C..vYK_3K_ARZqfneb_yJFbi3oom5rBKjE1sIr2TfCSleAC * src/third_party/perfetto: https://chromium.googlesource.com/external/github.com/google/perfetto.git/+log/d6a79b5507..42435b295e * src/third_party/r8/cipd: 9vZCRnASPSjh3_T-2AsumCO_8C5PuBJ5-e84K9b7-80C..wNwkeo57RtG4Npzb0tfhlH1x2KdM2va_nBHoHPPG9b0C * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/4d5f848ec7..bc4bc03601 DEPS diff: https://chromium.googlesource.com/chromium/src/+/238a28281c..9981aa6b34/DEPS BUG=None Change-Id: I6528613cf76090d23cda5289a291b10f7a238729 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/398262 Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#45038}
Bug: None Change-Id: I8788bcc56b283b25617def90385c01e312359fa9 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/398304 Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com> Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#45039}
adding suppressions for ALSA and Pulseaudio includes. Done using the usual find command piped into IWYU followed by replacing C style includes with C++ style includes where applicable. As usual followed by running tools_webrtc/gn_check_autofix.py and git cl format followed by some manual changes. Bug: webrtc:42226242 Change-Id: I12ad46de34b757bd02bbda0be83e1fe16d93f6ba Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/397901 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Henrik Andreassson <henrika@webrtc.org> Commit-Queue: Philipp Hancke <phancke@meta.com> Cr-Commit-Position: refs/heads/main@{#45040}
Change log: https://chromium.googlesource.com/chromium/src/+log/9981aa6b34..a17f285d6a Full diff: https://chromium.googlesource.com/chromium/src/+/9981aa6b34..a17f285d6a Changed dependencies * siso_version: git_revision:13b7a626dcadfb49c7f4759a44095cebea6e91bc..git_revision:4ac6aa83563aed91e78947b2b466eb6d49d51a21 * src/build: https://chromium.googlesource.com/chromium/src/build/+log/56959c64fe..d240ba2a7e * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/8fd088dba1..be4e5483d4 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/85552b7977..d13af77de0 * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/e7046a4d81..661640b823 * src/third_party/androidx/cipd: vYK_3K_ARZqfneb_yJFbi3oom5rBKjE1sIr2TfCSleAC..QJeiOfn7XeeO-RE3FDRufWNkhrsiuvv3LiJWr9X4k9QC * src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/57fbead964..ca6134f083 * src/third_party/compiler-rt/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/compiler-rt.git/+log/e070357d93..bb0007ce0e * src/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4f1723dd1f..5cc29c7a21 * src/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/a45468c0fc..c67de11737 * src/third_party/grpc/src: https://chromium.googlesource.com/external/github.com/grpc/grpc.git/+log/cce0ed4afb..1aca8c545f * src/third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/d9dd3097ff..97c89c7a7b * src/third_party/perfetto: https://chromium.googlesource.com/external/github.com/google/perfetto.git/+log/42435b295e..32fc4f31c3 * src/third_party/re2/src: https://chromium.googlesource.com/external/github.com/google/re2.git/+log/652b816bfd..8ea5841693 * src/third_party/siso/cipd: git_revision:13b7a626dcadfb49c7f4759a44095cebea6e91bc..git_revision:4ac6aa83563aed91e78947b2b466eb6d49d51a21 * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/bc4bc03601..ee56eb1f7d * src/tools/luci-go: git_revision:e18061c271a8bd452f0205e61ca71f872a48ba9c..git_revision:421eb17838d044c10a7cd661a68b5bfa2510f6af * src/tools/luci-go: git_revision:e18061c271a8bd452f0205e61ca71f872a48ba9c..git_revision:421eb17838d044c10a7cd661a68b5bfa2510f6af * src/tools/luci-go: git_revision:e18061c271a8bd452f0205e61ca71f872a48ba9c..git_revision:421eb17838d044c10a7cd661a68b5bfa2510f6af DEPS diff: https://chromium.googlesource.com/chromium/src/+/9981aa6b34..a17f285d6a/DEPS BUG=None Change-Id: I3c66ae8b5a6004ab21f4846de5043998d8d5c25c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/398427 Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#45041}
Bug: webrtc:419453427 Change-Id: I85586c277ceee01b1f5e11f6797fc2ce5de90b0a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/398321 Auto-Submit: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Åsa Persson <asapersson@webrtc.org> Commit-Queue: Åsa Persson <asapersson@webrtc.org> Cr-Commit-Position: refs/heads/main@{#45042}
To avoid relying on global field trials string in these unittests Bug: webrtc:419453427 Change-Id: I8f4f0836ae4ff0f05a69b0b728e5f9a5d0da744d Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/398282 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/main@{#45043}
This change defines a FullScreenWindowDetector for window captures while using WGC on Windows OS. FullScreenWindowDetector detects if an application exists in a full screen mode and if it does, then it tells the capturer to capture the full screen version of the application. Currently this works only for PowerPoint. This feature is protected behind a finch feature which will be landed in a follow-up CL in Chromium. Bug: chromium:409473386 Change-Id: I0f2eeaa5dfb00e76f08ab3a264df193cc643042e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/397640 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Palak Agarwal <agpalak@google.com> Cr-Commit-Position: refs/heads/main@{#45044}
FieldTrials are always no global now, there is no longer need to stress that in the factory name. Depending on the context, this function can be replace either with std::make_unique<FieldTrials>, FieldTrials::Create, or, in WebRTC unittests with CreateTestFieldTrials Bug: webrtc:419453427 Change-Id: I1bcdbb699f46a9d259ece5800eec37882fa3a936 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/398440 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/main@{#45045}
Change log: https://chromium.googlesource.com/chromium/src/+log/a17f285d6a..0a369bd359 Full diff: https://chromium.googlesource.com/chromium/src/+/a17f285d6a..0a369bd359 Changed dependencies * src/build: https://chromium.googlesource.com/chromium/src/build/+log/d240ba2a7e..de5b56f3da * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/be4e5483d4..93f68eb52f * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/d13af77de0..0c0e5c272b * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/661640b823..05e78517da * src/third_party/androidx/cipd: QJeiOfn7XeeO-RE3FDRufWNkhrsiuvv3LiJWr9X4k9QC..S2w6RUuVgvWR_5_Wroda8JA1Ye98v_unhD5qZEtEp1EC * src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/ca6134f083..92a0760977 * src/third_party/freetype/src: https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/58be4879c5..d7e640b9c6 * src/third_party/perfetto: https://chromium.googlesource.com/external/github.com/google/perfetto.git/+log/32fc4f31c3..5192b52b26 * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/ee56eb1f7d..740a7d8705 DEPS diff: https://chromium.googlesource.com/chromium/src/+/a17f285d6a..0a369bd359/DEPS BUG=None Change-Id: I766b2176fdf0fc0866a14b07934a4fc60e9ec39c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/398540 Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#45046}
These two classes were created with support for global field trials that is no longer used. All tests were migrated to use FieldTrials/CreateTestFieldTrials Bug: webrtc:419453427 Change-Id: I67cc259818b935fd66d2b6ae0afcb43c38762857 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/398481 Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Jeremy Leconte <jleconte@google.com> Cr-Commit-Position: refs/heads/main@{#45047}
This tools rely on VideoQualityTest fixture that was migrated to use propagated field trials that are populated from the same command line flag. Setting global field trials string has no effect and is no longer needed. Bug: webrtc:419453427 Change-Id: Ida7e55c771456f33894d98c6bff318a7dfbe1a78 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/398501 Reviewed-by: Åsa Persson <asapersson@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/main@{#45048}
Change log: https://chromium.googlesource.com/chromium/src/+log/0a369bd359..a0e5f7c8d3 Full diff: https://chromium.googlesource.com/chromium/src/+/0a369bd359..a0e5f7c8d3 Changed dependencies * src/build: https://chromium.googlesource.com/chromium/src/build/+log/de5b56f3da..af72f5c8c8 * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/93f68eb52f..b33f68ec2c * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/0c0e5c272b..1a3d23da3e * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/05e78517da..b61a3804b0 * src/third_party/android_build_tools/error_prone/cipd: KOECi08Fw4fRTVXkKocxg94coB-e_dlcHRokC21yxyoC..SUR9K2aNds6dKwrLTemfqjH4V0MHxW-rYXbm7dFLwMEC * src/third_party/androidx/cipd: S2w6RUuVgvWR_5_Wroda8JA1Ye98v_unhD5qZEtEp1EC..w54q1FmsAnoW84wRiVdrixqadZb5MTS3xUN_Dm_DDbMC * src/third_party/grpc/src: https://chromium.googlesource.com/external/github.com/grpc/grpc.git/+log/1aca8c545f..e332379ea8 * src/third_party/libyuv: https://chromium.googlesource.com/libyuv/libyuv.git/+log/9519b7df0e..007b920232 * src/third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/97c89c7a7b..00de13db4f * src/third_party/perfetto: https://chromium.googlesource.com/external/github.com/google/perfetto.git/+log/5192b52b26..c3b73394a5 * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/740a7d8705..83f4e0b3e9 DEPS diff: https://chromium.googlesource.com/chromium/src/+/0a369bd359..a0e5f7c8d3/DEPS BUG=None Change-Id: I167f902f2ecf51ceae11ec4207c627b2370ab83b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/398640 Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#45049}
Change log: https://chromium.googlesource.com/chromium/src/+log/a0e5f7c8d3..d0d4cc9913 Full diff: https://chromium.googlesource.com/chromium/src/+/a0e5f7c8d3..d0d4cc9913 Changed dependencies * src/build: https://chromium.googlesource.com/chromium/src/build/+log/af72f5c8c8..4f60484b8b * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/b33f68ec2c..b68c37d1d7 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/1a3d23da3e..e423886f97 * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/b61a3804b0..ecaab311b5 * src/third_party/android_build_tools/error_prone/cipd: SUR9K2aNds6dKwrLTemfqjH4V0MHxW-rYXbm7dFLwMEC..dFVMo_NVD5IoNgsCTx1nb8lGGNZNmY6xP94EJtjdm3sC * src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/78b48c1f2a..be5be0a4f5 * src/third_party/compiler-rt/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/compiler-rt.git/+log/bb0007ce0e..2a750528bb * src/third_party/freetype/src: https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/d7e640b9c6..39d85f1692 * src/third_party/grpc/src: https://chromium.googlesource.com/external/github.com/grpc/grpc.git/+log/e332379ea8..4bfda88b83 * src/third_party/perfetto: https://chromium.googlesource.com/external/github.com/google/perfetto.git/+log/c3b73394a5..b1756f9684 * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/83f4e0b3e9..dee299828e DEPS diff: https://chromium.googlesource.com/chromium/src/+/a0e5f7c8d3..d0d4cc9913/DEPS BUG=None Change-Id: Ia800be168a3e96e49cce7fb38eb08677dd82ffe1 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/398681 Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#45050}
Change log: https://chromium.googlesource.com/chromium/src/+log/d0d4cc9913..04a73c8df4 Full diff: https://chromium.googlesource.com/chromium/src/+/d0d4cc9913..04a73c8df4 Changed dependencies * src/build: https://chromium.googlesource.com/chromium/src/build/+log/4f60484b8b..3462f2bc1b * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/b68c37d1d7..8b6219b2e7 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/e423886f97..31b3aa0ddb * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/ecaab311b5..92e65b4509 * src/third_party/androidx/cipd: w54q1FmsAnoW84wRiVdrixqadZb5MTS3xUN_Dm_DDbMC..httE7hE1-HFsp32dX3_kpwXMpjBEgYONMrHEws9uOKgC * src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/be5be0a4f5..db421c2d80 * src/third_party/grpc/src: https://chromium.googlesource.com/external/github.com/grpc/grpc.git/+log/4bfda88b83..6238e8a4d7 * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/dee299828e..d61972c54f DEPS diff: https://chromium.googlesource.com/chromium/src/+/d0d4cc9913..04a73c8df4/DEPS BUG=None Change-Id: Ia87cdad8c4178da0f31fca75e6331ed0dd47b5a0 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/398685 Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#45051}
which hides details of the STUN implementation from the piggybacking controller. Bug: webrtc:367395350 Change-Id: I234bdef1d472b2cb2d2dc21ecd84a2f60a8967aa Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/394140 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Jonas Oreland <jonaso@webrtc.org> Commit-Queue: Jonas Oreland <jonaso@webrtc.org> Cr-Commit-Position: refs/heads/main@{#45052}
Bug: chromium:409473386 Change-Id: I4b0a01711ed710b9187837af3610163665a62ba5 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/398560 Commit-Queue: Palak Agarwal <agpalak@google.com> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#45053}
In unittests where it was used populate FieldTrials with CreateTestFieldTrials instead to ensure those tests respect command line flag --force_fieldtrials. Bug: webrtc:419453427 Change-Id: Id3c4b44397ee627c096cbbf4b06a4ee2f9757131 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/398480 Auto-Submit: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#45054}
Tests that use field trials were updated to populate field trials with CreateTestFieldTrials function and thus would use force_fieldtrials flags when provided. Bug: webrtc:419453427 Change-Id: I0ad50a75119ead85bf093b99f7c214d6adc9d031 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/398600 Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Jeremy Leconte <jleconte@google.com> Cr-Commit-Position: refs/heads/main@{#45055}
Change log: https://chromium.googlesource.com/chromium/src/+log/07ea83bdf3..b9a9162f68 Full diff: https://chromium.googlesource.com/chromium/src/+/07ea83bdf3..b9a9162f68 Changed dependencies * src/build: https://chromium.googlesource.com/chromium/src/build/+log/1923036296..38265dc962 * src/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/ea47cf7cad..6a6a2b6fd3 * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/f29c814c62..4ee187887e * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/dd35b2ddfc..d383bed741 * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/af97571ba5..2256781c1e * src/third_party/android_deps/autorolled/cipd: unni4p6XyH4fhaukKwB-7Y3-gYB4gcTBi-z4ceLA8IwC..RcN7kx5OuQtBLrhCRBTO9NABzT2sjw-ogJBZmT3nOdAC * src/third_party/androidx/cipd: 6Z_GY4GM81aHOyYjjxHX6_CtJPe1HejlEvqJ5dKEXh0C..FMvkqBv09hzZsC9bei-l-XsOPk7fhNz9OJiEZUr9XkoC * src/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c84d5af881..ba3926011b * src/third_party/grpc/src: https://chromium.googlesource.com/external/github.com/grpc/grpc.git/+log/eb189fb256..f2ac3f89c1 * src/third_party/libyuv: https://chromium.googlesource.com/libyuv/libyuv.git/+log/dd9ced1c6d..3ff31b2a5f * src/third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/33645b3d12..866857ce9c * src/third_party/perfetto: https://chromium.googlesource.com/external/github.com/google/perfetto.git/+log/90dc6864f1..3c2d2b9c28 * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/080b519309..3894cdec61 DEPS diff: https://chromium.googlesource.com/chromium/src/+/07ea83bdf3..b9a9162f68/DEPS BUG=None Change-Id: Iee27fac3af84eb6138437d57b2ad7d32f2d0a93b Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/402703 Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#45248}
Use RtpPacket derived classes instead as most callers already expect one of those Bug: webrtc:42225366 Change-Id: I719a0133608d86ba5ff2f2a93be8efa46ee159d3 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/402382 Reviewed-by: Åsa Persson <asapersson@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/main@{#45249}
Change log: https://chromium.googlesource.com/chromium/src/+log/b9a9162f68..fb179e390b Full diff: https://chromium.googlesource.com/chromium/src/+/b9a9162f68..fb179e390b Changed dependencies * src/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/6a6a2b6fd3..05da82cda1 * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/4ee187887e..c5987a5cb7 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/d383bed741..937c761860 * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/2256781c1e..86e10b5f5b * src/third_party/androidx/cipd: FMvkqBv09hzZsC9bei-l-XsOPk7fhNz9OJiEZUr9XkoC..OGWBgAeCj6FyxX6dFBASWD6km5fvC5NIb4npIG7XJckC * src/third_party/freetype/src: https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/8ceba9bbc5..6c18a397cb * src/third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/c105b13e37..1ce2525ae3 * src/third_party/perfetto: https://chromium.googlesource.com/external/github.com/google/perfetto.git/+log/3c2d2b9c28..6f02692503 * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/3894cdec61..3ea5338e9e DEPS diff: https://chromium.googlesource.com/chromium/src/+/b9a9162f68..fb179e390b/DEPS BUG=None Change-Id: I12fa41aa460ef42561a8cfc991138bf33672faed Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/402840 Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#45250}
to determine if a frame is a key frame. AOM_EFLAG_FORCE_KF is a flag passed to the encoder and should not be compared with the output aom_codec_frame_flags_t AOM_FRAME_IS_KEY even though both have the same value. drive-by bugfix from the bug linked below Bug: webrtc:434975748 Change-Id: I03a8ab385e7764d1064a51029c90d7ce6f54b7e0 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/402582 Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Philipp Hancke <phancke@meta.com> Cr-Commit-Position: refs/heads/main@{#45251}
GetCryptoOptions() initializes configuration_.crypto_options to default options if found uninitialized. This causes future SetConfiguration to fail even with an unmodified RTCConfig due to a trivial and no-op difference in crypto_options. So ignore a no-op difference and proceed with SetConfiguration in such cases. Also added tests that exercise this case. Bug: webrtc:42235111 Change-Id: If8c7bc0bdd06710e453c1157fee09819b0248aad Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/402800 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Auto-Submit: Sameer Vijaykar <samvi@google.com> Commit-Queue: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#45252}
All known implementations ignore that call. Bug: None Change-Id: I0bdce66c4d4c2e498fbc72166726451fc24fd60a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/402780 Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Commit-Position: refs/heads/main@{#45253}
Bug: webrtc:42235111 Change-Id: I92d56d9912d5587ef5aabcf556b942ce5eaf4e26 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/402680 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Commit-Queue: Philipp Hancke <phancke@meta.com> Cr-Commit-Position: refs/heads/main@{#45254}
Change log: https://chromium.googlesource.com/chromium/src/+log/fb179e390b..3566b11a24 Full diff: https://chromium.googlesource.com/chromium/src/+/fb179e390b..3566b11a24 Changed dependencies * src/build: https://chromium.googlesource.com/chromium/src/build/+log/38265dc962..5aa7284188 * src/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/05da82cda1..eec146f235 * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/c5987a5cb7..db9615377b * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/937c761860..076615a381 * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/86e10b5f5b..201042f918 * src/third_party/compiler-rt/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/compiler-rt.git/+log/d507e8c884..a0b0e482f9 * src/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ba3926011b..e5797fdfad * src/third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/1ce2525ae3..c105b13e37 * src/third_party/perfetto: https://chromium.googlesource.com/external/github.com/google/perfetto.git/+log/6f02692503..54b52ebe0a * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/3ea5338e9e..f2a011f7da * src/tools/luci-go: git_revision:f2aee64d8d98e4fe969d433785e969f3effe90c6..git_revision:299f8fef82a4bbdedf3cae74b19bd883dc3fa9a5 * src/tools/luci-go: git_revision:f2aee64d8d98e4fe969d433785e969f3effe90c6..git_revision:299f8fef82a4bbdedf3cae74b19bd883dc3fa9a5 * src/tools/luci-go: git_revision:f2aee64d8d98e4fe969d433785e969f3effe90c6..git_revision:299f8fef82a4bbdedf3cae74b19bd883dc3fa9a5 DEPS diff: https://chromium.googlesource.com/chromium/src/+/fb179e390b..3566b11a24/DEPS BUG=None Change-Id: I62aabac7952ec8f452e4714c738f3f788987be75 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/402861 Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#45255}
presumably the issues have been fixed in libvpx and abseil since 2019. Also remove dynamic cast suppression since dynamic cast is not allowed by the WebRTC styleguide and not used. Bug: webrtc:42221195 Change-Id: I6ec370c207447e5ad6a36bafbc32dd73af4b3dc3 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/402605 Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org> Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org> Cr-Commit-Position: refs/heads/main@{#45256}
using git ls-files | grep BUILD.gn | xargs gn format which seems to induce a shorter notation for cases like - "../../api/rtc_event_log:rtc_event_log", + "../../api/rtc_event_log", now. Bug: None Change-Id: I362627095f3d0391603d9f642d14fdadba58ca66 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/402860 Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Philipp Hancke <phancke@meta.com> Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Cr-Commit-Position: refs/heads/main@{#45257}
Change log: https://chromium.googlesource.com/chromium/src/+log/3566b11a24..bc83480c62 Full diff: https://chromium.googlesource.com/chromium/src/+/3566b11a24..bc83480c62 Changed dependencies * src/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/eec146f235..f319b82deb * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/db9615377b..cea7efb776 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/076615a381..95648f980d * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/201042f918..92ba2417c8 * src/third_party/android_build_tools/lint/cipd: aS4jV08o7OzcMeyyL2RcyXM0e8V2feomEKdqh8nowjwC..a7lcD6DTdd0SsdsWaWYRA3YtuyQ6lK_sI1AyWsfybAUC * src/third_party/androidx/cipd: OGWBgAeCj6FyxX6dFBASWD6km5fvC5NIb4npIG7XJckC..GfQMtSFNJqDhXsiVfqiKYojheKME-AgiqeQps6UXT7QC * src/third_party/boringssl/src: https://boringssl.googlesource.com/boringssl.git/+log/4b32850023..ddb2ca4b48 * src/third_party/grpc/src: https://chromium.googlesource.com/external/github.com/grpc/grpc.git/+log/f2ac3f89c1..5ec3db4db8 * src/third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/c105b13e37..1ce2525ae3 * src/third_party/perfetto: https://chromium.googlesource.com/external/github.com/google/perfetto.git/+log/54b52ebe0a..3e0dbdb048 * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/f2a011f7da..885dfa88f3 DEPS diff: https://chromium.googlesource.com/chromium/src/+/3566b11a24..bc83480c62/DEPS BUG=None Change-Id: I7a80f85d5066e7038ada6efb2cc2456cd29aa3f3 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/402902 Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#45258}
Change log: https://chromium.googlesource.com/chromium/src/+log/bc83480c62..6246a14961 Full diff: https://chromium.googlesource.com/chromium/src/+/bc83480c62..6246a14961 Changed dependencies * src/build: https://chromium.googlesource.com/chromium/src/build/+log/5aa7284188..d71f61071f * src/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/f319b82deb..8568004b4e * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/cea7efb776..c028e10c58 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/95648f980d..5329f2a161 * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/92ba2417c8..41cded040f * src/third_party/android_build_tools/manifest_merger/cipd: XY78mpSqG9c2zsRPfLI2m16ihBltxa3R27qOXhV9WMIC..BtwPLnZ4Yj5iZzjKdg7hRenTE46-D94IYZZ9V1M5DK8C * src/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e5797fdfad..d85491b0a1 * src/third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/866857ce9c..cea0dc1411 * src/third_party/perfetto: https://chromium.googlesource.com/external/github.com/google/perfetto.git/+log/3e0dbdb048..cab3e8dcac * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/885dfa88f3..e242b0db59 * src/tools/luci-go: git_revision:299f8fef82a4bbdedf3cae74b19bd883dc3fa9a5..git_revision:69966f1a4984c4ade24b8e2e1af0bbc51b64d3c0 * src/tools/luci-go: git_revision:299f8fef82a4bbdedf3cae74b19bd883dc3fa9a5..git_revision:69966f1a4984c4ade24b8e2e1af0bbc51b64d3c0 * src/tools/luci-go: git_revision:299f8fef82a4bbdedf3cae74b19bd883dc3fa9a5..git_revision:69966f1a4984c4ade24b8e2e1af0bbc51b64d3c0 DEPS diff: https://chromium.googlesource.com/chromium/src/+/bc83480c62..6246a14961/DEPS BUG=None Change-Id: Id32d16f11a7c91d0230367235f07d88c7c9136fd Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/402906 Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#45259}
This change adds additional logic where we verify if the visible rectangle of the full screen window is the same as the display monitor. This change also introduces checking the window style of the full screen window to not be an overlapped window. The overlapped window style includes the minimized or maximized box style, which was the earlier requirement. Bug: chromium:409473386 Change-Id: I3fbaf362769ba302f0ee1f6012e6b773ac95b882 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/402742 Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org> Commit-Queue: Palak Agarwal <agpalak@google.com> Cr-Commit-Position: refs/heads/main@{#45260}
Change log: https://chromium.googlesource.com/chromium/src/+log/6246a14961..e3ed81b4ae Full diff: https://chromium.googlesource.com/chromium/src/+/6246a14961..e3ed81b4ae Changed dependencies * src/build: https://chromium.googlesource.com/chromium/src/build/+log/d71f61071f..85917ab732 * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/c028e10c58..054c8ae1ab * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/5329f2a161..e2034a233a * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/41cded040f..1ac7f380a6 * src/third_party/androidx/cipd: GfQMtSFNJqDhXsiVfqiKYojheKME-AgiqeQps6UXT7QC..B83vmV8nan6y-jdaamQyzhSD5dw4rAa3CJOUfsyEDXAC * src/third_party/perfetto: https://chromium.googlesource.com/external/github.com/google/perfetto.git/+log/cab3e8dcac..4c0ba925d3 * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/e242b0db59..078a9b75e5 DEPS diff: https://chromium.googlesource.com/chromium/src/+/6246a14961..e3ed81b4ae/DEPS BUG=None Change-Id: Ie9c147d520a4acb54e6699e92b388f6c629f7bf5 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/402909 Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#45261}
Merge all constructors into single one Pass Environment instead of its components separately Hide AlrDetectorConfig from public api Unwrap unique_ptr<AlrDetector> as AlrDetector is never moved Bug: None Change-Id: I80ca6bc5fad60074e5f5fb94c496173726c56764 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/402641 Auto-Submit: Danil Chapovalov <danilchap@webrtc.org> Commit-Queue: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Björn Terelius <terelius@webrtc.org> Cr-Commit-Position: refs/heads/main@{#45262}
Change log: https://chromium.googlesource.com/chromium/src/+log/e3ed81b4ae..7148957153 Full diff: https://chromium.googlesource.com/chromium/src/+/e3ed81b4ae..7148957153 Changed dependencies * src/build: https://chromium.googlesource.com/chromium/src/build/+log/85917ab732..a5f1980e01 * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/054c8ae1ab..f1dac4d0f2 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/e2034a233a..dedcff6486 * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/1ac7f380a6..0f481e100d * src/third_party/catapult: https://chromium.googlesource.com/catapult.git/+log/4e4076a0d7..0fd1415f0c * src/third_party/freetype/src: https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/6c18a397cb..08805be530 * src/third_party/grpc/src: https://chromium.googlesource.com/external/github.com/grpc/grpc.git/+log/5ec3db4db8..890fc8feba * src/third_party/libyuv: https://chromium.googlesource.com/libyuv/libyuv.git/+log/3ff31b2a5f..cdd3bae848 * src/third_party/perfetto: https://chromium.googlesource.com/external/github.com/google/perfetto.git/+log/4c0ba925d3..d248102abc * src/third_party/re2/src: https://chromium.googlesource.com/external/github.com/google/re2.git/+log/66a656e6d9..8451125897 * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/078a9b75e5..64612a0adf DEPS diff: https://chromium.googlesource.com/chromium/src/+/e3ed81b4ae..7148957153/DEPS BUG=None Change-Id: I0b24dde25ee406df618e7a1db84bd0a22f2f0ef2 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/402912 Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#45263}
using git ls-files | xargs tools_webrtc/iwyu/apply-include-cleaner followed by tools_webrtc/gn_check_autofix.py followed by git cl format Bug: webrtc:42226242 Change-Id: I885a45b8fe48830c228b7d9c6fb02c32210347fa Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/402900 Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Philipp Hancke <phancke@meta.com> Cr-Commit-Position: refs/heads/main@{#45264}
Now that RegisterBufferCollectionArgs can carry a sysmem2 token, avoid a token conversion. Bug: b/306258175 Change-Id: Icc675d1d11cecce821a771c149bea988b2d341a9 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/382862 Commit-Queue: Dustin Green <dustingreen@google.com> Reviewed-by: Mark Foltz <mfoltz@chromium.org> Reviewed-by: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/main@{#45265}
Change log: https://chromium.googlesource.com/chromium/src/+log/7148957153..3fa528657e Full diff: https://chromium.googlesource.com/chromium/src/+/7148957153..3fa528657e Changed dependencies * src/build: https://chromium.googlesource.com/chromium/src/build/+log/a5f1980e01..66d076c7ab * src/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/8568004b4e..0c4bbb0f8a * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/f1dac4d0f2..3d985df122 * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/dedcff6486..022148d78c * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/0f481e100d..4eeb0dbca2 * src/third_party/androidx/cipd: B83vmV8nan6y-jdaamQyzhSD5dw4rAa3CJOUfsyEDXAC..IG08WxVoI4_gwNrbpXqXXmytPWFopEI1x0EaFC1KosAC * src/third_party/compiler-rt/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/compiler-rt.git/+log/a0b0e482f9..50e43403df * src/third_party/libc++/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/1ce2525ae3..adbb4a5210 * src/third_party/perfetto: https://chromium.googlesource.com/external/github.com/google/perfetto.git/+log/d248102abc..0c893ed6bf * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/64612a0adf..64f4fc6277 DEPS diff: https://chromium.googlesource.com/chromium/src/+/7148957153..3fa528657e/DEPS BUG=None Change-Id: I86f03748574383f2057dcbe1b7cc012b2c52a5e5 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/402914 Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#45266}
Bug: None Change-Id: I110aff9729d301fa082118ac038ca7ea3afa8679 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/402915 Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com> Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#45267}
Change log: https://chromium.googlesource.com/chromium/src/+log/3fa528657e..8b8c7a1de2 Full diff: https://chromium.googlesource.com/chromium/src/+/3fa528657e..8b8c7a1de2 Changed dependencies * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/3d985df122..9994d1901c * src/testing: https://chromium.googlesource.com/chromium/src/testing/+log/022148d78c..305de9533d * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/4eeb0dbca2..eaf896de73 * src/third_party/android_build_tools/error_prone/cipd: V1UaojOb1ghWxbzvm7e3KAo4E5L41McXcK_4S37dQWAC..56Xo0VEDkKxzOr5L7pafI6SaIY2S7wnOOcgy4CNSANEC * src/third_party/android_build_tools/lint/cipd: a7lcD6DTdd0SsdsWaWYRA3YtuyQ6lK_sI1AyWsfybAUC..AGywP4kNoPZjZa3fVdf1g2cKgEPkXnVFRxhlFjroXJcC * src/third_party/android_build_tools/manifest_merger/cipd: BtwPLnZ4Yj5iZzjKdg7hRenTE46-D94IYZZ9V1M5DK8C..K-0K2jznbc6LGEnKhT8NliSShwC43TBuVFZ6gRjOuxgC * src/third_party/grpc/src: https://chromium.googlesource.com/external/github.com/grpc/grpc.git/+log/890fc8feba..f83ae79333 * src/third_party/kotlin_stdlib/cipd: __UeKdzo8RtzJ15lT8YJ9fh4B4kpIcbfAbVDMJU9yxoC..jHhaILmhjHo4cYTvCdIRMwWPOAGSwjhEtrMxwREj52gC * src/third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/cea0dc1411..2ce8ed6c36 * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/64f4fc6277..0562c6fd86 DEPS diff: https://chromium.googlesource.com/chromium/src/+/3fa528657e..8b8c7a1de2/DEPS BUG=None Change-Id: Ieea24f8958c64067aa645aa29099f3cfcf14c313 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/402948 Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#45268}
Bug: None Change-Id: I717eb18a41d59594bc9f8babcab5ef4959c01f3a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/403001 Bot-Commit: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com> Commit-Queue: webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com <webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#45269}
Change log: https://chromium.googlesource.com/chromium/src/+log/8b8c7a1de2..2fda948e24 Full diff: https://chromium.googlesource.com/chromium/src/+/8b8c7a1de2..2fda948e24 Changed dependencies * src/ios: https://chromium.googlesource.com/chromium/src/ios/+log/9994d1901c..e11547b2c2 * src/third_party: https://chromium.googlesource.com/chromium/src/third_party/+log/eaf896de73..e30091e898 * src/third_party/compiler-rt/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/compiler-rt.git/+log/50e43403df..dc425afb37 * src/third_party/grpc/src: https://chromium.googlesource.com/external/github.com/grpc/grpc.git/+log/f83ae79333..806e186735 * src/third_party/llvm-libc/src: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/2ce8ed6c36..8ec6b26421 * src/tools: https://chromium.googlesource.com/chromium/src/tools/+log/0562c6fd86..ec8f1c6113 DEPS diff: https://chromium.googlesource.com/chromium/src/+/8b8c7a1de2..2fda948e24/DEPS BUG=None Change-Id: I96a9ece65cccaf7493ea58ff61b3f7f229c9f390 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/403041 Commit-Queue: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Bot-Commit: Autoroller <chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#45270}
rtcp-mux and rtcp-rsize are unconditionally set for datachannel but since they are not serialized in the SDP they are not parsed. This leads the munging detector to misclassify this. a unit test is added as a separate CL for easier backmerging. (cherry picked from commit 602b06b1125ea4d107fbfbda7d314b4157c4c74b) Bug: webrtc:414284082,chromium:40567530 Fixed: chromium:439807581 Change-Id: I4ebb2ad5062ea42fc47a314ed929de42f91bbea7 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/404740 Commit-Queue: Philipp Hancke <phancke@meta.com> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Cr-Original-Commit-Position: refs/heads/main@{#45357} Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/405281 Cr-Commit-Position: refs/branch-heads/7339@{#1} Cr-Branched-From: 9bd6475-refs/heads/main@{#45270}
DTLS 1.3 considers itself connected earlier than DTLS 1.2 did - when second flight reaches the client. This CL fixes a bug that when client is connected (state_ != SSL_CONNECTING), it would not continue retransmitting. Continuous retransmission is needed when the third flight is lost multiple times. Or really anytime that DTLS request it :) This fixes the TODO in dtls_ice_integrationtest.cc in which dtls1.3 spuriously failed with certain (packet loss intensive) configurations. CREDITS: sergeysu@ that found and fixed the problem! (cherry picked from commit 4221e1b) No-Try: true Bug: chromium:441245658, chromium:441486101 Change-Id: I3302f6f384d7e4cda090184094a6fadaf7e4f129 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/406320 Reviewed-by: Tomas Gunnarsson <tommi@webrtc.org> Reviewed-by: Harald Alvestrand <hta@webrtc.org> Commit-Queue: Jonas Oreland <jonaso@webrtc.org> Cr-Original-Commit-Position: refs/heads/main@{#45439} Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/407780 Commit-Queue: Guido Urdaneta <guidou@webrtc.org> Cr-Commit-Position: refs/branch-heads/7339@{#2} Cr-Branched-From: 9bd6475-refs/heads/main@{#45270}
# Conflicts: # pc/channel.cc # pc/congestion_control_integrationtest.cc # pc/peer_connection_integrationtest.cc # sdk/objc/native/api/audio_device_module.h # sdk/objc/native/api/audio_device_module.mm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.