Add support for adding attachments directly from an InputStream. #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before only File where supported, however, Google App Engine does not allow applications access to the filesystem, thus where unable to attach any attachments.
Contributor
|
This looks quite good. Thanks for this. I'm reviewing and then merging in. |
motdotla
added a commit
that referenced
this pull request
Nov 21, 2013
Add support for adding attachments directly from an InputStream.
Contributor
|
Ok, this is live in |
Contributor
|
@foens shoot me an email at motte@sendgrid.com. I'd like to mail you a shirt for your help with this. |
Contributor
Author
|
Please check pull #14. It updates the README to reflect the changes in the API. Will send you an email. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before only File where supported, however, Google App Engine does not
allow applications access to the filesystem, thus where unable to attach
any attachments.
This pull request fixes #8