Add custom timestamp filtration #500
Conversation
| assert all(timestamp.tzinfo is not None for timestamp in timestamps) | ||
|
|
||
| def test_get_available_timestamps_custom_filtration(self): | ||
| """Chekcs that the custom filtration works as intended.""" |
ColinMoldenhauer
left a comment
ColinMoldenhauer
left a comment
There was a problem hiding this comment.
Looks good to me, thank you for the quick action!
As an e-mail, you can use colin.moldenhauer [at] posteo.de, thank you! |
Co-authored-by: Colin Moldenhauer <colin.moldenhauer@posteo.de>
Codecov ReportBase: 83.60% // Head: 83.58% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #500 +/- ##
===========================================
- Coverage 83.60% 83.58% -0.02%
===========================================
Files 60 60
Lines 5683 5685 +2
===========================================
+ Hits 4751 4752 +1
- Misses 932 933 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Code looks good. len(set(timestamp)) == len(timestamp filtration) != len(timestamp))and make doc strings unified whit existing doc strings. |
Closes #498
@ColinMoldenhauer is this sufficient for your needs? I would also like to add you as a co-author (since the idea and solution suggestion are yours), but I'd need an e-mail under which to add you.