Skip to content

Conversation

@armcknight
Copy link
Contributor

@armcknight armcknight commented Sep 22, 2023

Provide a way to generate large amounts of DB entities, so that subsequent fetches take long enough to cause "DB on main thread" issues.

I was able to see DB on Main Thread issues now after generating large amounts of db records and relaunching the app to load them all at once: https://demo.sentry.io/issues/4542023700/?project=6249899&query=is%3Aunresolved+se%3Aandrewmcknight&referrer=issue-stream&statsPeriod=14d&stream_index=0

Here's a quick demo of how to generate the items:

db.mods.mov

There's also a launch argument you can use to immediately wipe the database if you find it's taking too long to launch the app and you want to start over (make sure not to commit the xcscheme file in git with this enabled):
image

closes #25

@armcknight armcknight marked this pull request as draft September 22, 2023 23:49
@armcknight armcknight changed the title meta: extract and improve upload symbol script feat: generate "DB on main thread" issues Sep 22, 2023
@armcknight

This comment was marked as outdated.

@armcknight armcknight force-pushed the armcknight/feat/25-database-on-main-thread branch from 49d47e2 to c66e371 Compare September 22, 2023 23:53
@armcknight armcknight changed the base branch from armcknight/meta/improve-upload-symbol-script to master September 22, 2023 23:53
@armcknight armcknight changed the base branch from master to armcknight/fix/navbar-invisibility October 5, 2023 21:37
@armcknight armcknight force-pushed the armcknight/feat/25-database-on-main-thread branch from c66e371 to 2a15519 Compare October 5, 2023 21:37
Base automatically changed from armcknight/fix/navbar-invisibility to master October 6, 2023 17:57
@armcknight armcknight marked this pull request as ready for review October 12, 2023 00:36
@armcknight armcknight mentioned this pull request Oct 12, 2023
11 tasks
@kpujjigit kpujjigit self-requested a review October 12, 2023 16:15
@kpujjigit
Copy link
Contributor

Verified Working

image

@kpujjigit kpujjigit merged commit e480f60 into master Oct 12, 2023
@kpujjigit kpujjigit deleted the armcknight/feat/25-database-on-main-thread branch October 12, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create "Database on Main Thread" Performance Issue

2 participants