ReactNative Android README update for sdk 5.9.1 #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

thinkocapo merged 15 commits into sentry-demos:master from thinkocapo:will-run

Sep 27, 2023

Contributor

thinkocapo commented Sep 12, 2023 •

edited

Loading

Overview

This PR was opened in order to test the RN and RN Sentry SDK updates by krystofwoldrich, and to run the TDA tests against it. The TDA testing is tracked in sentry-demos/empower#277

See commands in 'Run Android'
Not evaluating 'Run iOS' section in this PR. It's old info that will be tested once the RN-Android release are uploaded to Github and TDA is running succesfully on it.
Moved several Troubleshooting sections to Troubleshooting.md, like 'How to Bootstrap a RN+Sentry App for First Time', so the README is more readable, and it's easier to find the Setup vs Run instructions.
Updated Version Dependencies for build tools.

thinkocapo added 3 commits

September 9, 2023 13:21


          updated readme. troubleshooting.md. latest commands and versions

30419e0


          fixed conflicts


          updates

3663bd5

thinkocapo requested a review from krystofwoldrich

September 12, 2023 08:37

thinkocapo added 5 commits

September 13, 2023 12:13


          changes

9efe593


          readme good

225a413


          troubleshooting


          Merge branch 'master' into will-run

a648169


          updates

f8ccd61

thinkocapo requested review from ndmanvar and sdzhong

September 22, 2023 08:38

krystofwoldrich reviewed

View reviewed changes

README.md Outdated Show resolved Hide resolved

krystofwoldrich reviewed

View reviewed changes

README.md Outdated Show resolved Hide resolved

krystofwoldrich reviewed

View reviewed changes

README.md Outdated Show resolved Hide resolved

krystofwoldrich reviewed

View reviewed changes

README.md Show resolved Hide resolved

krystofwoldrich reviewed

View reviewed changes

README.md Outdated Show resolved Hide resolved

krystofwoldrich reviewed

View reviewed changes

README.md Outdated Show resolved Hide resolved

Contributor

krystofwoldrich commented Sep 22, 2023

I have some small suggestions, but overall looks good. 👍

I haven't commented on the todos in trouble shooting as they will be addressed in sentry-demos/empower#277

thinkocapo and others added 7 commits

September 27, 2023 09:56


          Update README.md

0d89797

Co-authored-by: Kryštof Woldřich <31292499+krystofwoldrich@users.noreply.github.com>


          Update README.md

53133d9

Co-authored-by: Kryštof Woldřich <31292499+krystofwoldrich@users.noreply.github.com>


          Update README.md

4ece0f2

Co-authored-by: Kryštof Woldřich <31292499+krystofwoldrich@users.noreply.github.com>


          Update README.md

2b39c04

Co-authored-by: Kryštof Woldřich <31292499+krystofwoldrich@users.noreply.github.com>


          Update README.md

811a038

Co-authored-by: Kryštof Woldřich <31292499+krystofwoldrich@users.noreply.github.com>


          Update build.gradle

fc396db

includeSourceContext true


          Update README.md

6b3017f

assembleRelease comment

krystofwoldrich reviewed

View reviewed changes

README.md Show resolved Hide resolved

krystofwoldrich approved these changes

View reviewed changes

Contributor

krystofwoldrich left a comment

I've noticed one more version with "?".

Thanks for writing all the commands. It's a handy guide.

thinkocapo merged commit 3d130a4 into sentry-demos:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet