Skip to content

Fix AsyncJsonRpcClient to reuse HttpClient #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2025
Merged

Fix AsyncJsonRpcClient to reuse HttpClient #120

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/asynch/clients/json_rpc/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,15 @@ mod _std {

pub struct AsyncJsonRpcClient {
url: Url,
client: HttpClient,
}

impl AsyncJsonRpcClient {
pub fn connect(url: Url) -> Self {
Self { url }
Self {
url,
client: HttpClient::new(),
}
}
}

Expand All @@ -58,9 +62,9 @@ mod _std {
&self,
request: XRPLRequest<'a>,
) -> XRPLClientResult<XRPLResponse<'b>> {
let client = HttpClient::new();
let request_json_rpc = request_to_json_rpc(&request)?;
let response = client
let response = self
.client
.post(self.url.as_ref())
.json(&request_json_rpc)
.send()
Expand Down
Loading