Fix type validations being to strict for dates#6453
Merged
sushantdhiman merged 2 commits intosequelize:v3from Aug 19, 2016
fintura:fix-dates
Merged
Fix type validations being to strict for dates#6453sushantdhiman merged 2 commits intosequelize:v3from fintura:fix-dates
sushantdhiman merged 2 commits intosequelize:v3from
fintura:fix-dates
Conversation
Member
|
LGTM - Needs a rebase |
Member
|
Do you mind creating this for the master branch as well? |
Contributor
Author
|
Done |
Contributor
|
LGTM |
holm
pushed a commit
to peakon/sequelize
that referenced
this pull request
Aug 19, 2016
* Fix type validations being to strict for dates * Add changelog entry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
npm run testornpm run test-DIALECTpass with this change (including linting)?Futurein the changelog?Description of change
Currently the type validations for dates are very strict. Most of the type validations accept strings as input and this should also be the case for dates as far as I see it.