Skip to content

Conversation

@fzn0x
Copy link
Member

@fzn0x fzn0x commented Nov 10, 2021

Pull Request Checklist

Please make sure to review and check all of these items:

  • Have you added new tests to prevent regressions?
  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description Of Change

Look like some important PRs is staled and closed, so I'm adding days-before-pr-close: -1 to avoid PRs being closed without assignees or contributors permission.

Todos

  • Add days-before-pr-close: -1

@fzn0x fzn0x requested a review from sdepold November 10, 2021 07:38
@WikiRik
Copy link
Member

WikiRik commented Nov 10, 2021

On that note, maybe also add a label that prevents issues from becoming stale?

@sdepold
Copy link
Member

sdepold commented Nov 10, 2021

That would be extremely good indeed

@fzn0x
Copy link
Member Author

fzn0x commented Nov 10, 2021

🐈 nice tip @WikiRik would happy to progress on it

@WikiRik
Copy link
Member

WikiRik commented Nov 12, 2021

@fncolon is it okay if we merge this now and I'll make a PR for the exempt labels? Before more PRs get closed by the bot

@fzn0x
Copy link
Member Author

fzn0x commented Nov 13, 2021

@fncolon is it okay if we merge this now and I'll make a PR for the exempt labels? Before more PRs get closed by the bot

It's okay, i would appreciate it.

@fzn0x fzn0x removed the request for review from sdepold November 13, 2021 03:53
@fzn0x fzn0x requested review from WikiRik and sdepold November 13, 2021 03:53
Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I will make a new PR for the exempt labels tomorrow or on Monday

@sdepold sdepold merged commit 13e8b83 into main Nov 15, 2021
@sdepold sdepold deleted the fncolon-patch-1 branch November 15, 2021 18:26
@github-actions
Copy link
Contributor

🎉 This PR is included in version 6.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

aliatsis pushed a commit to creditiq/sequelize that referenced this pull request Jun 2, 2022
Co-authored-by: Sascha Depold <sdepold@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants