Fix updating of the topographic elevations#67
Merged
Conversation
[skip ci]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request does a few things but it is mainly intended to fix a problem where the topographic elevations were not being updated correctly after running the components each time step. To fix this, I've changed all of the components to no longer update derived fields such as elevation. Instead, components only add to the current amount of subsidence or sediment deposited. At the end of each time step the sequence model uses these fields to calculate derived fields such as the topography and the elevation of bedrock. The subsidence rates and deposition rates are then reset before running the next time step. This also has the advantage of removing any dependency on the ordering of components.