Introduce TravisCI, Coveralls, Linters and fix found problems #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
zimmski
force-pushed
the
travis-coveralls-linters
branch
from
a815942 to
ab120fe
Compare
This test fails every time the race detector is on. Also, there was a lying comment.
The bytes.Buffer.WriteString has the superb property of "err is always nil", so we can just ignore it. However, we explicitly ignore it so that we can use errcheck without ignoring everything.
Remove unreachable code.
It should be "DiffPrettyHTML" but we cannot change the API.
zimmski
force-pushed
the
travis-coveralls-linters
branch
from
ab120fe to
73c5334
Compare
|
Changes Unknown when pulling 73c5334 on travis-coveralls-linters into * on master*. |
zimmski
changed the title
sergi
approved these changes
Oct 13, 2016
Owner
sergi
left a comment
sergi
left a comment
There was a problem hiding this comment.
Great! Really nice to freshen up the codebase :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sergi: TravisCI and Coveralls need to be enabled before merging this PR. Also, the Coveralls token is also needed for this PR. I will amend the commit after you have sent it to me.
I found a lot of things we could improve in the code :-)