Throw when using hooks with a shared file

Author: cocowalla

src/Serilog.Sinks.File/FileLoggerConfigurationExtensions.cs

@@ -301,6 +301,7 @@ static LoggerConfiguration ConfigureFile(
             if (fileSizeLimitBytes.HasValue && fileSizeLimitBytes < 0) throw new ArgumentException("Negative value provided; file size limit must be non-negative.", nameof(fileSizeLimitBytes));
             if (retainedFileCountLimit.HasValue && retainedFileCountLimit < 1) throw new ArgumentException("At least one file must be retained.", nameof(retainedFileCountLimit));
             if (shared && buffered) throw new ArgumentException("Buffered writes are not available when file sharing is enabled.", nameof(buffered));
+            if (shared && hooks != null) throw new ArgumentException("Unable to use {hooks.GetType().Name} FileLifecycleHooks output stream wrapper - these are not supported for shared log files", nameof(hooks));
 
             ILogEventSink sink;
 
@@ -315,11 +316,6 @@ static LoggerConfiguration ConfigureFile(
 #pragma warning disable 618
                     if (shared)
                     {
-                        if (hooks != null)
-                        {
-                            SelfLog.WriteLine($"Unable to use {hooks.GetType().Name} FileLifecycleHooks output stream wrapper - these are not supported for shared log files");
-                        }
-
                         sink = new SharedFileSink(path, formatter, fileSizeLimitBytes);
                     }
                     else

test/Serilog.Sinks.File.Tests/FileLoggerConfigurationExtensionsTests.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Threading;
 using Serilog.Sinks.File.Tests.Support;
 using Serilog.Tests.Support;
@@ -80,11 +80,11 @@ public void WhenFlushingToDiskReportedSharedFileSinkCanBeCreatedAndDisposed()
         }
 
         [Fact]
-        public void BufferingIsNotAvailableWhenSharingEnabled()
+        public void HooksAreNotAvailableWhenSharingEnabled()
         {
             Assert.Throws<ArgumentException>(() =>
                 new LoggerConfiguration()
-                    .WriteTo.File("logs", buffered: true, shared: true));
+                    .WriteTo.File("logs", shared: true, hooks: new GZipHooks()));
         }
     }
 }