2.0.2 Release #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…data completion (#3)
Fix ObjectDisposedException for auto subscriptions when logger is disposed
ghuntley
suggested changes
Nov 14, 2017
| <PackageReference Include="xunit" Version="2.3.0" /> | ||
| <PackageReference Include="xunit.runner.visualstudio" Version="2.3.0" /> | ||
|
|
||
| <PackageReference Include="Rx-Main" Version="2.2.5" /> |
Member
There was a problem hiding this comment.
This should be changed to System.Reactive at version 3.11. Note Rx-Main is incompatible with System.Reactive and the same is true in inverse. FYI - The rest of the Reactive Extensions ecosystem has standardized using the netstandard release (System.Reactive @ 311). Any questions ask away!
Member
Author
There was a problem hiding this comment.
Thanks, will try to make those changes in dev when I have a chance 👍
Shouldn't hold up this release, as it's only in the test project. Merge ahoy!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ObjectDisposedExceptionon sink shut-down