Skip to content

Conversation

@msclock
Copy link
Contributor

@msclock msclock commented Mar 20, 2024

Signed-off-by: msclock <msclock@qq.com>
@msclock msclock force-pushed the pre-commit branch 2 times, most recently from d8f24ab to bd9d104 Compare March 20, 2024 08:28
@msclock msclock marked this pull request as draft March 20, 2024 09:04
@msclock msclock marked this pull request as ready for review March 22, 2024 09:29
@msclock msclock requested a review from huxuan March 22, 2024 09:30
Copy link
Member

@huxuan huxuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, I may also suggest to group the update of renovate docker tag and renovate pre-commit tag. But it is OK to do it in a separate pull request since it also changes the logic in template generation.

@msclock msclock requested a review from huxuan March 23, 2024 09:39
@huxuan huxuan merged commit 9baf17a into serious-scaffold:main Mar 23, 2024
@huxuan huxuan mentioned this pull request Mar 25, 2024
@msclock msclock deleted the pre-commit branch April 16, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants